Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coodirnator: optimize the detectiong timeout for ip conflict and gateway detection #4512

Conversation

cyclinder
Copy link
Collaborator

Thanks for contributing!

Notice:

What issue(s) does this PR fix:

Fixes #4508

Special notes for your reviewer:

@cyclinder cyclinder changed the title coodirnator: set timeout for ip and gateway detection coodirnator: optimize the detectiong timeout for ip conflict and gateway detection Jan 3, 2025
@cyclinder cyclinder linked an issue Jan 3, 2025 that may be closed by this pull request
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 83.58209% with 11 lines in your changes missing coverage. Please review.

Project coverage is 80.58%. Comparing base (16fd442) to head (1268120).
Report is 3 commits behind head on release-v0.8.

Files with missing lines Patch % Lines
pkg/utils/utils.go 83.58% 7 Missing and 4 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-v0.8    #4512       +/-   ##
=================================================
+ Coverage          1.40%   80.58%   +79.17%     
=================================================
  Files                54       50        -4     
  Lines              6332     5552      -780     
=================================================
+ Hits                 89     4474     +4385     
+ Misses             6233      906     -5327     
- Partials             10      172      +162     
Flag Coverage Δ
unittests 80.58% <83.58%> (+79.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/utils/utils.go 68.86% <83.58%> (ø)

... and 54 files with indirect coverage changes

@cyclinder cyclinder force-pushed the 0.8_cp/coordinator_detect_timeout1 branch from 9f45801 to 5e0a1c7 Compare January 3, 2025 03:35
@cyclinder cyclinder requested review from ty-dc and bzsuni as code owners January 3, 2025 03:47
@weizhoublue weizhoublue merged commit fe98554 into spidernet-io:release-v0.8 Jan 3, 2025
49 of 50 checks passed
@cyclinder cyclinder deleted the 0.8_cp/coordinator_detect_timeout1 branch January 3, 2025 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed to cherry pick PR 4504 from cyclinder, to branch release-v0.8
2 participants