Rescope expression then the identity is a struct dtype #1887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Cargo.lock # Cargo.toml # vortex-expr/Cargo.toml # vortex-expr/src/lib.rs
joseph-isaacs
changed the title
joseph-isaacs
changed the title
gatesn
approved these changes
Jan 11, 2025
vortex-expr/src/select.rs
Outdated
| @@ -23,6 +23,14 @@ pub struct Select { | |||
| child: ExprRef, | |||
| } | |||
|
|
|||
| pub fn select(columns: Vec<Field>, child: ExprRef) -> ExprRef { | |||
There was a problem hiding this comment.
I thought these were fields, not columns?
| use crate::traversal::{FoldChildren, FoldUp, FolderMut, Node}; | ||
| use crate::{ExprRef, GetItem, Pack}; | ||
|
|
||
| pub struct ExprSimplify(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defines a transform on expression with an scope type of struct(..). The transform splits the expr in to a series of expressions that can be evaluated only using a single field of the struct, and a combination expr which combines the series of smaller expr into the original expr.
This is used #1893.