Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[timer][fix] Fix duration type check for Timer #456

Merged
merged 1 commit into from
Dec 30, 2024
Merged

[timer][fix] Fix duration type check for Timer #456

merged 1 commit into from
Dec 30, 2024

Conversation

naveedhd
Copy link
Collaborator

for #432 and #435

sea-bass
sea-bass approved these changes Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sea-bass sea-bass merged commit d0b3214 into splintered-reality:devel Dec 30, 2024
5 checks passed
@naveedhd naveedhd deleted the timer-typecheck-fix branch December 30, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sea-bass sea-bass sea-bass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naveedhd @sea-bass