Fix dirty flag set to false on same value put

spring-projects · Oct 27, 2024 · 05e79f3 · 05e79f3
1 parent cf44ca8
commit 05e79f3
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/...g-batch-infrastructure/src/main/java/org/springframework/batch/item/ExecutionContext.java b/...g-batch-infrastructure/src/main/java/org/springframework/batch/item/ExecutionContext.java
@@ -37,6 +37,7 @@
  * @author Lucas Ward
  * @author Douglas Kaminsky
  * @author Mahmoud Ben Hassine
+ * @author Seokmun Heo
  */
 public class ExecutionContext implements Serializable {
 
@@ -124,7 +125,11 @@ public void putDouble(String key, double value) {
 	public void put(String key, @Nullable Object value) {
 		if (value != null) {
 			Object result = this.map.put(key, value);
-			this.dirty = result == null || !result.equals(value);
+			boolean newDirty = result == null || !result.equals(value);
+
+			if (!this.dirty) {
+				this.dirty = newDirty;
+			}
 		}
 		else {
 			Object result = this.map.remove(key);

diff --git a/...ch-infrastructure/src/test/java/org/springframework/batch/item/ExecutionContextTests.java b/...ch-infrastructure/src/test/java/org/springframework/batch/item/ExecutionContextTests.java
@@ -30,7 +30,7 @@
 /**
  * @author Lucas Ward
  * @author Mahmoud Ben Hassine
- *
+ * @author Seokmun Heo
  */
 class ExecutionContextTests {
 
@@ -161,6 +161,15 @@ void testCopyConstructorNullInput() {
 		assertTrue(context.isEmpty());
 	}
 
+	@Test
+	void testDirtyWithDuplicate() {
+		ExecutionContext context = new ExecutionContext();
+		context.put("1", "testString1");
+		assertTrue(context.isDirty());
+		context.put("1", "testString1"); // put the same value
+		assertTrue(context.isDirty());
+	}
+
 	/**
 	 * Value object for testing serialization
 	 */