Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Support Node.js Execution Environment for SSX #104

Closed
wants to merge 10 commits into from

Conversation

skgbafa
Copy link
Contributor

@skgbafa skgbafa commented Mar 8, 2023

Description

This adds support for signers in the node execution environment (such as ethers) instead of assuming a browser environment. It also adds an example in node. This addresses #83

Type

  • New feature (non-breaking change which adds functionality)

Diligence Checklist

(Please delete options that are not relevant)

  • This change requires a documentation update
  • I have included unit tests
  • I have updated and/or included new integration tests
  • I have updated and/or included new end-to-end tests
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@CLAassistant
Copy link

CLAassistant commented Mar 8, 2023

CLA assistant check
All committers have signed the CLA.

@skgbafa skgbafa changed the title [WIP] Feat/support node [WIP] Support Node.js Execution Environment for SSX Mar 8, 2023
@skgbafa skgbafa force-pushed the feat/support-node branch from 12644d6 to 1b52a86 Compare March 8, 2023 16:04

constructor(private config?: SSXClientConfig) { }
constructor(private config?: SSXClientConfig) {
this.executionEnvironment = typeof process.versions.node !== 'undefined' ? 'node' : 'browser';
Copy link

@searchableguy searchableguy Mar 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this configurable perhaps? I would like to use it with other runtime or in other context where we do not have a browser wallet.

@skgbafa skgbafa force-pushed the feat/support-node branch from 3d1c5dd to 2cfd7ba Compare March 29, 2023 14:57
@skgbafa
Copy link
Contributor Author

skgbafa commented May 10, 2023

Closing for now. We are overhauling ssx and adding support for node as part of this. Part of the challenge for this PR has to do this have to do with the wasm bundle we use, it's build for the browser to be able to be consumed by downstream packages. Adding support for node is nontrivial and we are going to do this while we update our wasm and rust bundling process for ssx-rs.

@skgbafa skgbafa closed this May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants