-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Support Node.js Execution Environment for SSX #104
Conversation
12644d6
to
1b52a86
Compare
packages/ssx-sdk/src/core.ts
Outdated
|
||
constructor(private config?: SSXClientConfig) { } | ||
constructor(private config?: SSXClientConfig) { | ||
this.executionEnvironment = typeof process.versions.node !== 'undefined' ? 'node' : 'browser'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this configurable perhaps? I would like to use it with other runtime or in other context where we do not have a browser wallet.
3d1c5dd
to
2cfd7ba
Compare
Closing for now. We are overhauling ssx and adding support for node as part of this. Part of the challenge for this PR has to do this have to do with the wasm bundle we use, it's build for the browser to be able to be consumed by downstream packages. Adding support for node is nontrivial and we are going to do this while we update our wasm and rust bundling process for ssx-rs. |
Description
This adds support for signers in the node execution environment (such as ethers) instead of assuming a browser environment. It also adds an example in node. This addresses #83
Type
Diligence Checklist
(Please delete options that are not relevant)