fix show_tooltip for AHK v2 #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensures that arguments are correctly parsed as numbers when provided and fixes a problem in AHKv2 where the tooltip window creation may be blocked by returning to the blocking daemon input loop until the next command invocation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ensures that arguments are correctly parsed as numbers when provided and fixes a problem in AHKv2 where the tooltip window creation may be blocked by returning to the blocking daemon input loop until the next command invocation
Previously, an error may be thrown when
xoryparameters were not provided when using AHK v2 and tooltips for successful calls may be delayed until a subsequent command is received.Completes the fix from #362 and fully resolves #361
This also reverts a change that pinned
mypyto 1.13.0 to avoid new typing issues that arose with abstract methods when upgradingmypyto 1.14.1 -- the typing issues were resolved and mypy has been unpinned.