quick-setup: allow running script without setup-sshd function #2381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jklare
commented
Jan 8, 2025
jklare
commented
- although the setup-sshd function seems useful for certain cases, it is generally unrelated to what the rest of the script does and strictly not needed for most people
- to allow people to run the script without also modifying the sshd config on their servers (which might be considered a security violation in some contexts), this patch introduces an additional environment variable "SETUP_SSH", which can be set to "false" (or any other value than "true") to disable running the setup-sshd function
- to not break backward compatibility and keep the current functionality the same, the default value for this variable is set to "true"
|
Thanks, @jklare |
* although the setup-sshd function seems useful for certain cases, it is generally unrelated to what the rest of the script does and strictly not needed for most people * to allow people to run the script without also modifying the sshd config on their servers (which might be considered a security violation in some contexts), this patch introduces an additional environment variable "SETUP_SSH", which can be set to "false" (or any other value than "true") to disable running the setup-sshd function * to not break backward compatibility and keep the current functionality the same, the default value for this variable is set to "true" Signed-off-by: Jan Klare <[email protected]>
|
@hellt Thanks for the quick review, done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.