Fixed using Symfony Serializer with RabbitMQ. #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@weaverryan @sroze Can this get merged? |
|
Hey. Could you rebase your PR please? |
Nyholm
reviewed
Jan 19, 2020
| { | ||
| $context = $this->contextManager->context(); | ||
| $encodedMessage = $this->serializer->encode($envelope); | ||
|
|
||
| if ($context instanceof AmqpContext | ||
| && !$this->serializer instanceof PhpSerializer |
There was a problem hiding this comment.
What if someone is using .a different serializer?
I dont really understand why we should special treat AMQP context and PHPSerializer. Could you please explain that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes using Symfony Serializer with RabbitMQ.
Using QueueInteropTransport with RabbitMQ and Symfony Serializer will now send stamps. This also fixes Messenger retries because it uses stamps.
This fixes issue #86.