-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/extensive refactor #221
Open
VictorM-Coder
wants to merge
32
commits into
sstrickx:develop
Choose a base branch
from
VictorM-Coder:refactor/extensive-refactor
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactor/extensive refactor #221
VictorM-Coder
wants to merge
32
commits into
sstrickx:develop
from
VictorM-Coder:refactor/extensive-refactor
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stock class refactored
refactor GodClass
Refactor/excessive params list
…od-length refactored
…-method-length refactored
…nght Refactor/excessive method lenght
…ngth Refactor/excessive method length
Refactor/method lenght
refactor FxSymbols
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolution of Issue #220
Taking the issue for code quality improvement of the system as a reference, focusing on addressing code smells, we performed code refactoring for some duplicated codes and ExcessiveClassLength code smell
Code Analysis
After performing the necessary refactoring, we ran PMD once again following the same directives indicated in the issue and found the following results (indicating that we were able to address the aforementioned code smells):]
Notion