Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for venv override fact #33

Merged
merged 2 commits into from
Mar 19, 2024
Merged

fix for venv override fact #33

merged 2 commits into from
Mar 19, 2024

Conversation

g0rgamesh
Copy link
Contributor

Set fact takes precedence over virtual environment variable in other roles:
IDENTITY_API_VERSION=3 /usr/bin/python3 /home/stack/.ansible/tmp/ansible-tmp-1710852078.3961973-1188828-59557818542981/AnsiballZ_network.py && sleep 0' <127.0.0.1> EXEC /bin/sh -c 'rm -f -r /home/stack/.ansible/tmp/ansible-tmp-1710852078.3961973-1188828-59557818542981/ > /dev/null 2>&1 && sleep 0'

@g0rgamesh g0rgamesh requested a review from a team as a code owner March 19, 2024 13:13
@g0rgamesh g0rgamesh requested a review from markgoddard March 19, 2024 13:14
Copy link

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change it to use the same pattern used in the other roles, e.g. os_flavors?

@g0rgamesh
Copy link
Contributor Author

Could you change it to use the same pattern used in the other roles, e.g. os_flavors?

Sure

@g0rgamesh g0rgamesh requested a review from markgoddard March 19, 2024 14:14
@markgoddard markgoddard merged commit fab9b06 into main Mar 19, 2024
4 checks passed
@markgoddard markgoddard deleted the unset_venv_fix branch March 19, 2024 14:28
@g0rgamesh
Copy link
Contributor Author

We should make a new collection release, it's needed for customer CI.

@markgoddard
Copy link

We should make a new collection release, it's needed for customer CI.

Done: https://github.com/stackhpc/ansible-collection-openstack/releases/tag/0.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants