Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add os_openstacksdk role #4

Merged
merged 10 commits into from
Nov 23, 2023
Merged

Add os_openstacksdk role #4

merged 10 commits into from
Nov 23, 2023

Conversation

markgoddard
Copy link

  • Add os_openstacksdk role
  • lint: Fix os_openstacksdk test import role name
  • lint: Add auto-fixes for collection
  • lint: Add auto-fixes for os_openstacksdk
  • os_openstacksdk: Improve whitespace
  • lint: Fix openstacksdk issues
  • os_openstacksdk: Fix README example
  • os_openstacksdk: Add to collection README

@markgoddard markgoddard requested a review from a team as a code owner November 23, 2023 11:00
@markgoddard markgoddard self-assigned this Nov 23, 2023
grzegorzkoper
grzegorzkoper approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@grzegorzkoper grzegorzkoper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@markgoddard markgoddard merged commit 5fe6ce9 into main Nov 23, 2023
4 checks passed
@markgoddard markgoddard deleted the sdk branch November 23, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grzegorzkoper grzegorzkoper grzegorzkoper approved these changes

Assignees

@markgoddard markgoddard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markgoddard @grzegorzkoper