Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add os_networks role #7

Merged
merged 7 commits into from
Dec 1, 2023
Merged

Add os_networks role #7

merged 7 commits into from
Dec 1, 2023

Conversation

markgoddard
Copy link

  • Add os_networks role
  • lint: os_networks auto-fixes
  • lint: Ignore os_networks variable prefix
  • lint: Fix os_networks issues
  • os_networks: Update README
  • os_networks: Drop Python 2 support

@markgoddard markgoddard requested a review from a team as a code owner November 23, 2023 12:32
@markgoddard markgoddard self-assigned this Nov 23, 2023
g0rgamesh
g0rgamesh previously approved these changes Nov 23, 2023
@g0rgamesh g0rgamesh self-requested a review November 23, 2023 16:27
@g0rgamesh g0rgamesh dismissed their stale review November 23, 2023 16:31

2 tests failed

@g0rgamesh
Copy link
Contributor

2 tests failed

@markgoddard
Copy link
Author

It failed due to the missing dependency on the openstack.cloud collection, added with os-deploy-templates.

Rebased and now fixed.

@scrungus
Copy link
Contributor

scrungus commented Nov 29, 2023

@markgoddard It seems like a newer version of openstacksdk is required:

TASK [stackhpc.openstack.os_networks : Ensure network is registered with neutron] *******************************************************************************************************************************************************************
... "msg": "Incompatible openstacksdk library found: Version MUST be >=1.0 and <=None, but 0.62.0 is smaller than minimum version 1.0."}

This would be covered by the antelope upper constraints. As you said, may be worth trying to unify the constraints of the roles as it's also required by images + container templates

This is required for openstacksdk > 1.0, required for openstack.cloud modules.
@markgoddard
Copy link
Author

@markgoddard It seems like a newer version of openstacksdk is required:

TASK [stackhpc.openstack.os_networks : Ensure network is registered with neutron] *******************************************************************************************************************************************************************
... "msg": "Incompatible openstacksdk library found: Version MUST be >=1.0 and <=None, but 0.62.0 is smaller than minimum version 1.0."}

This would be covered by the antelope upper constraints. As you said, may be worth trying to unify the constraints of the roles as it's also required by images + container templates

Good catch, updated.

Copy link
Contributor

@scrungus scrungus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and working in devstack

@markgoddard markgoddard merged commit 8f718d5 into main Dec 1, 2023
4 checks passed
@markgoddard markgoddard deleted the networks branch December 1, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants