feat: "StarkNet" to "Starknet" #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for starknetjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
0xdorifto
changed the title
0xdorifto
changed the title
|
@janek26 @dhruvkelawala @yoga-braavos can you please give your input about this? 🙏 |
|
relevant: |
penovicp
requested changes
Oct 5, 2023
penovicp
force-pushed
the
0xdorifto_StarkNet_to_Starknet
branch
from
c11f166 to
9a2e0e0
Compare
penovicp
approved these changes
Oct 7, 2023
✅ Deploy Preview for starknetjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This should be combined with off-chain signing PR |
penovicp
force-pushed
the
0xdorifto_StarkNet_to_Starknet
branch
from
927846e to
800091e
Compare
penovicp
force-pushed
the
0xdorifto_StarkNet_to_Starknet
branch
from
800091e to
c9a81bb
Compare
|
🎉 This PR is included in version 6.0.0-beta.14 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This issue has been resolved in version 7.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Resolution
Because the official name is "Starknet", remove all instances of "StarkNet" in favour of "Starknet".
Issue: #705
Usage related changes
Development related changes
Checklist: