Remove show all from search result if there's no results #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flashy78
reviewed
Mar 1, 2024
| ? [{ label: "Scenes", options: scenes }] | ||
| : []; | ||
| const showAll = | ||
| showAllLink && performerResults.length > 0 && sceneResults.length > 0 |
There was a problem hiding this comment.
I think this should probably be:
const showAll = showAllLink && (performerResults.length > 0 || sceneResults.length > 0)
Right now if there are no performer results, but multiple scene results, I can't go to the main search results page to see which one I want, I have to pick one from the dropdown. If it's not the one I wanted, I have to re-type the search and choose another one from the dropdown, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.