Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't connect Hermez wallet dApp to Status wallet #11925

Closed
guylouis opened this issue Mar 24, 2021 · 3 comments · Fixed by #11943
Closed

Can't connect Hermez wallet dApp to Status wallet #11925

guylouis opened this issue Mar 24, 2021 · 3 comments · Fixed by #11943
Assignees

Comments

@guylouis
Copy link
Contributor

guylouis commented Mar 24, 2021

Issue
As a user I can't connect Hermez wallet dApp (https://wallet.hermez.io/login) to my status wallet

Reproduction

  • in Status browser browse https://wallet.hermez.io/login
  • click on 'connect with metamask'
  • the user then gets the following error "input is invalid type"
    IMG_03F4D93CC4E8-1
@guylouis guylouis added the bug label Mar 24, 2021
@flexsurfer
Copy link
Member

for some reason page won't load on iphone

@flexsurfer flexsurfer self-assigned this Mar 24, 2021
@flexsurfer
Copy link
Member

flexsurfer commented Mar 25, 2021

ok on android i can see it uses both eth_sign and signTypedData_v4, both not supported by status, personal_sign is supported instead of eth_sign and signTypedData_v4 blocked by MetaMask/eth-sig-util#106, so i guess its time to just implement both just to be compatible with MM? cc @cammellos

@flexsurfer
Copy link
Member

eth_sign can be just supported by personal_sign in status, i guess latest dapps and libraries use eth_sign as personal_sign with same parameters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants