Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#11925] Can't connect Hermez wallet dApp to Status wallet #11943

Merged
merged 2 commits into from
Apr 19, 2021
Merged

[#11925] Can't connect Hermez wallet dApp to Status wallet #11943

merged 2 commits into from
Apr 19, 2021

Conversation

flexsurfer
Copy link
Member

@flexsurfer flexsurfer commented Mar 31, 2021 •
edited
Loading

fixes: #11925

eth_sign support
eth_signTypedData_v4 support

@flexsurfer flexsurfer self-assigned this Mar 31, 2021
@status-im-auto
Copy link
Member

status-im-auto commented Mar 31, 2021 •
edited
Loading

Jenkins Builds

Click to see older builds (12)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 2c05586 #1 2021-03-31 07:42:36 ~9 min android 📦apk 📲
✔️ 2c05586 #1 2021-03-31 07:45:38 ~12 min android-e2e 📦apk 📲
✔️ 2c05586 #1 2021-03-31 07:48:48 ~15 min ios 📦ipa 📲
✔️ d0453d8 #2 2021-03-31 10:15:55 ~9 min android 📦apk 📲
✔️ d0453d8 #2 2021-03-31 10:17:49 ~11 min android-e2e 📦apk 📲
✔️ d0453d8 #2 2021-03-31 10:22:11 ~15 min ios 📦ipa 📲
✔️ de2cdb0 #3 2021-04-16 11:16:56 ~15 min android 📦apk 📲
✔️ de2cdb0 #3 2021-04-16 11:17:03 ~15 min android-e2e 📦apk 📲
❌ de2cdb0 #4 2021-04-19 10:16:27 ~18 sec ios 📄log
✔️ 4bf44ae #4 2021-04-19 10:41:42 ~13 min android 📦apk 📲
✔️ 4bf44ae #5 2021-04-19 10:45:25 ~17 min ios 📦ipa 📲
✔️ 4bf44ae #4 2021-04-19 10:46:57 ~19 min android-e2e 📦apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e4cb94e #5 2021-04-19 11:44:09 ~12 min android 📦apk 📲
✔️ e4cb94e #5 2021-04-19 11:46:07 ~14 min android-e2e 📦apk 📲
✔️ e4cb94e #6 2021-04-19 11:51:59 ~20 min ios 📦ipa 📲
✔️ f9b542d #6 2021-04-19 13:06:23 ~14 min android-e2e 📦apk 📲
✔️ f9b542d #6 2021-04-19 13:10:33 ~18 min android 📦apk 📲
✔️ f9b542d #7 2021-04-19 13:12:14 ~20 min ios 📦ipa 📲

@flexsurfer flexsurfer requested a review from cammellos March 31, 2021 10:06
@status-im-auto
Copy link
Member

99% of end-end tests have passed

Total executed tests: 80
Failed tests: 1
Passed tests: 79

IDs of failed tests: 3994

Failed tests (1)

Click to expand
1. test_create_new_group_chat_messaging_pn_delived, id: 3994

Device 2: =========================================================================
Device 2: *Find Button by xpath:* `//*[contains(@text, "Message from device: 1")]`

Device 2: Button by xpath: `//*[contains(@text, "Message from device: 1")]` is not found on the screen

Device sessions

Passed tests (79)

Click to expand
1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
Device sessions

2. test_add_account_to_multiaccount_instance_generate_new, id: 6224
Device sessions

3. test_send_eth_from_wallet_to_address, id: 5308
Device sessions

4. test_onboarding_screen_when_requesting_tokens_for_recovered_account, id: 5677
Device sessions

5. test_keycard_can_see_all_transactions_in_history, id: 6291
Device sessions

6. test_push_notification_1_1_chat, id: 6283
Device sessions

7. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
Device sessions

8. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
Device sessions

9. test_open_public_chat_using_deep_link, id: 5396
Device sessions

10. test_offline_add_new_group_chat_member, id: 3998
Device sessions

11. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
Device sessions

12. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
Device sessions

13. test_keycard_create_login_resotore_unlock_same_seed, id: 5689
Device sessions

14. test_insufficient_funds_wallet_positive_balance, id: 5412
Device sessions

15. test_delete_close_all_tabs, id: 5390
Device sessions

16. test_send_token_with_7_decimals, id: 5350
Device sessions

17. test_delete_chats_via_delete_button_rejoin, id: 5387
Device sessions

18. test_send_transaction_set_recipient_options, id: 6328
Device sessions

19. test_recover_account_from_new_user_seedphrase, id: 6296
Device sessions

20. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
Device sessions

21. test_block_user_from_public_chat, id: 5786
Device sessions

22. test_send_audio_message_with_push_notification_check, id: 6316
Device sessions

23. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
Device sessions

24. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
Device sessions

25. test_keycard_send_eth_from_wallet_to_address, id: 6289
Device sessions

26. test_request_public_key_status_test_daap, id: 5397
Device sessions

27. test_sign_message_from_daap, id: 5342
Device sessions

28. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
Device sessions

29. test_back_forward_refresh_navigation_history_kept_after_relogin (TestRail link is not found)
Device sessions

30. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
Device sessions

31. test_redirect_to_public_chat_tapping_tag_message, id: 5675
Device sessions

32. test_keycard_send_two_transactions_one_after_another_in_dapp, id: 6288
Device sessions

33. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
Device sessions

34. test_long_press_to_delete_chat, id: 5319
Device sessions

35. test_copy_and_paste_messages, id: 5317
Device sessions

36. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
Device sessions

37. test_unread_messages_counter_public_chat, id: 5360
Device sessions

38. test_user_can_see_all_own_assets_after_account_recovering, id: 5381
Device sessions

39. test_transaction_wrong_password_wallet, id: 5408
Device sessions

40. test_mobile_data_usage_complex_settings, id: 6228
Device sessions

41. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
Device sessions

42. test_send_two_transactions_one_after_another_in_dapp, id: 5744
Device sessions

43. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
Device sessions

44. test_send_eth_in_1_1_chat_transaction_push, id: 6253
Device sessions

45. test_fetch_more_history_in_empty_chat, id: 6205
Device sessions

46. test_install_pack_and_send_sticker, id: 5782
Device sessions

47. test_keycard_send_two_transactions_in_batch_in_dapp, id: 6287
Device sessions

48. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
Device sessions

49. test_keycard_sign_message_from_daap, id: 6251
Device sessions

50. test_manage_assets, id: 5341
Device sessions

51. test_send_two_transactions_in_batch_in_dapp, id: 5743
Device sessions

52. test_browser_managing_bookmarks, id: 6633
Device sessions

53. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
Device sessions

54. test_request_stt_from_daap, id: 5309
Device sessions

55. test_send_emoji, id: 5328
Device sessions

56. test_can_use_purchased_stickers_on_recovered_account, id: 5783
Device sessions

57. test_dapps_permissions, id: 5738
Device sessions

58. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
Device sessions

59. test_send_eth_to_ens_in_chat, id: 6279
Device sessions

60. test_share_copy_contact_code_and_wallet_address, id: 5323
Device sessions

61. test_wallet_set_up, id: 5335
Device sessions

62. test_send_transaction_with_custom_token, id: 6208
Device sessions

63. test_home_view, id: 5379
Device sessions

64. test_can_add_existing_ens, id: 5502
Device sessions

65. test_logcat_backup_recovery_phrase, id: 5419
Device sessions

66. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
Device sessions

67. test_set_profile_picture, id: 6646
Device sessions

68. test_collectible_from_wallet, id: 5346
Device sessions

69. test_public_chat_messaging, id: 5313
Device sessions

70. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
Device sessions

71. test_keycard_request_stt_from_daap, id: 6249
Device sessions

72. test_restore_account_from_mnemonic_to_keycard, id: 6240
Device sessions

73. test_pass_phrase_validation, id: 5363
Device sessions

74. test_keycard_send_eth_in_1_1_chat, id: 6293
Device sessions

75. test_send_and_open_links_with_previews, id: 5373
Device sessions

76. test_reactions_to_message_in_chats, id: 6315
Device sessions

77. test_filters_from_daap, id: 5353
Device sessions

78. test_fetching_balance_after_offline, id: 6237
Device sessions

79. test_keycard_fetching_balance_after_offline, id: 6290
Device sessions

@status-im-auto
Copy link
Member

96% of end-end tests have passed

Total executed tests: 80
Failed tests: 3
Passed tests: 77

IDs of failed tests: 6253,3994,6237

Failed tests (3)

Click to expand
1. test_send_eth_in_1_1_chat_transaction_push, id: 6253

Device 1: *TimeStampText is 5:46 PM*
Device 1: *Wait for text element TransactionStatus to be equal to Pending*

Device 1: 'Confirmed' is not equal to expected 'Pending' in 30 sec

Device sessions

2. test_create_new_group_chat_messaging_pn_delived, id: 3994

Device 2: =========================================================================
Device 2: *Find Button by xpath:* `//*[contains(@text, "Message from device: 1")]`

Device 2: Button by xpath: `//*[contains(@text, "Message from device: 1")]` is not found on the screen

Device sessions

3. test_fetching_balance_after_offline, id: 6237

Transaction #5, amount is 0.003117657
{'blockNumber': '9950960', 'timeStamp': '1617210488', 'hash': '0x0be160f0bf7a34da81c265a28f94cb4620c0d8a16887e2a4a42998a67b008f43', 'nonce': '2128', 'blockHash': '0x884d03edb53a1ada4e5653455cd5157ca45d9c2997821bf82e57e41689c47e44', 'from': '0xc8f8b3376814d0dfe61e4b9eaf7970697c24f6b2', 'contractAddress': '0xc55cf4b03948d7ebc8b9e8bad92643703811d162', 'to': '0xf184747445c3b85ceb147dfb136067cb93d95f1d', 'value': '3117657000000000', 'tokenName': 'Status Test Token', 'tokenSymbol': 'STT', 'tokenDecimal': '18', 'transactionIndex': '0', 'gas': '125182', 'gasPrice': '35000000000', 'gasUsed': '104319', 'cumulativeGasUsed': '104319', 'input': 'deprecated', 'confirmations': '292'}

Transaction with amount 0.0031175312 is not found in list of token transactions, address is f184747445c3B85CEb147DfB136067CB93d95F1D during 600s

Device sessions

Passed tests (77)

Click to expand
1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
Device sessions

2. test_add_account_to_multiaccount_instance_generate_new, id: 6224
Device sessions

3. test_send_eth_from_wallet_to_address, id: 5308
Device sessions

4. test_onboarding_screen_when_requesting_tokens_for_recovered_account, id: 5677
Device sessions

5. test_keycard_can_see_all_transactions_in_history, id: 6291
Device sessions

6. test_push_notification_1_1_chat, id: 6283
Device sessions

7. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
Device sessions

8. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
Device sessions

9. test_open_public_chat_using_deep_link, id: 5396
Device sessions

10. test_offline_add_new_group_chat_member, id: 3998
Device sessions

11. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
Device sessions

12. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
Device sessions

13. test_keycard_create_login_resotore_unlock_same_seed, id: 5689
Device sessions

14. test_insufficient_funds_wallet_positive_balance, id: 5412
Device sessions

15. test_delete_close_all_tabs, id: 5390
Device sessions

16. test_send_token_with_7_decimals, id: 5350
Device sessions

17. test_delete_chats_via_delete_button_rejoin, id: 5387
Device sessions

18. test_send_transaction_set_recipient_options, id: 6328
Device sessions

19. test_recover_account_from_new_user_seedphrase, id: 6296
Device sessions

20. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
Device sessions

21. test_block_user_from_public_chat, id: 5786
Device sessions

22. test_send_audio_message_with_push_notification_check, id: 6316
Device sessions

23. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
Device sessions

24. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
Device sessions

25. test_keycard_send_eth_from_wallet_to_address, id: 6289
Device sessions

26. test_request_public_key_status_test_daap, id: 5397
Device sessions

27. test_sign_message_from_daap, id: 5342
Device sessions

28. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
Device sessions

29. test_back_forward_refresh_navigation_history_kept_after_relogin (TestRail link is not found)
Device sessions

30. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
Device sessions

31. test_redirect_to_public_chat_tapping_tag_message, id: 5675
Device sessions

32. test_keycard_send_two_transactions_one_after_another_in_dapp, id: 6288
Device sessions

33. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
Device sessions

34. test_long_press_to_delete_chat, id: 5319
Device sessions

35. test_copy_and_paste_messages, id: 5317
Device sessions

36. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
Device sessions

37. test_unread_messages_counter_public_chat, id: 5360
Device sessions

38. test_user_can_see_all_own_assets_after_account_recovering, id: 5381
Device sessions

39. test_transaction_wrong_password_wallet, id: 5408
Device sessions

40. test_mobile_data_usage_complex_settings, id: 6228
Device sessions

41. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
Device sessions

42. test_send_two_transactions_one_after_another_in_dapp, id: 5744
Device sessions

43. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
Device sessions

44. test_fetch_more_history_in_empty_chat, id: 6205
Device sessions

45. test_install_pack_and_send_sticker, id: 5782
Device sessions

46. test_keycard_send_two_transactions_in_batch_in_dapp, id: 6287
Device sessions

47. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
Device sessions

48. test_keycard_sign_message_from_daap, id: 6251
Device sessions

49. test_manage_assets, id: 5341
Device sessions

50. test_send_two_transactions_in_batch_in_dapp, id: 5743
Device sessions

51. test_browser_managing_bookmarks, id: 6633
Device sessions

52. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
Device sessions

53. test_request_stt_from_daap, id: 5309
Device sessions

54. test_send_emoji, id: 5328
Device sessions

55. test_can_use_purchased_stickers_on_recovered_account, id: 5783
Device sessions

56. test_dapps_permissions, id: 5738
Device sessions

57. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
Device sessions

58. test_send_eth_to_ens_in_chat, id: 6279
Device sessions

59. test_share_copy_contact_code_and_wallet_address, id: 5323
Device sessions

60. test_wallet_set_up, id: 5335
Device sessions

61. test_send_transaction_with_custom_token, id: 6208
Device sessions

62. test_home_view, id: 5379
Device sessions

63. test_can_add_existing_ens, id: 5502
Device sessions

64. test_logcat_backup_recovery_phrase, id: 5419
Device sessions

65. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
Device sessions

66. test_set_profile_picture, id: 6646
Device sessions

67. test_collectible_from_wallet, id: 5346
Device sessions

68. test_public_chat_messaging, id: 5313
Device sessions

69. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
Device sessions

70. test_keycard_request_stt_from_daap, id: 6249
Device sessions

71. test_restore_account_from_mnemonic_to_keycard, id: 6240
Device sessions

72. test_pass_phrase_validation, id: 5363
Device sessions

73. test_keycard_send_eth_in_1_1_chat, id: 6293
Device sessions

74. test_send_and_open_links_with_previews, id: 5373
Device sessions

75. test_reactions_to_message_in_chats, id: 6315
Device sessions

76. test_filters_from_daap, id: 5353
Device sessions

77. test_keycard_fetching_balance_after_offline, id: 6290
Device sessions

@flexsurfer
Copy link
Member Author

waiting for v4

@flexsurfer flexsurfer closed this Apr 12, 2021
@flexsurfer flexsurfer reopened this Apr 12, 2021
@flexsurfer flexsurfer requested a review from cammellos April 12, 2021 14:00
@flexsurfer flexsurfer changed the title eth_sign support [#11925] Can't connect Hermez wallet dApp to Status wallet Apr 16, 2021
@flexsurfer
Copy link
Member Author

@Serhy ready for testing

@qoqobolo qoqobolo self-assigned this Apr 19, 2021
@flexsurfer @cammellos
v4
adaf77b 
Signed-off-by: Andrea Maria Piana <[email protected]>
@cammellos cammellos merged commit adaf77b into develop Apr 19, 2021
@cammellos cammellos deleted the feature/eth-sign branch April 19, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cammellos cammellos cammellos approved these changes

Assignees

@flexsurfer flexsurfer

@qoqobolo qoqobolo

Labels
request-manual-qa Tested - OK
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't connect Hermez wallet dApp to Status wallet
4 participants
@flexsurfer @status-im-auto @cammellos @qoqobolo