implement signTypedData_V4 for Keycard and handle chainID whether it is a string or a number #12109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (3)
|
100% of end-end tests have passedPassed tests (80)Click to expand
|
bitgamma
changed the title
cammellos
approved these changes
May 12, 2021
Signed-off-by: Michele Balistreri <[email protected]>
100% of end-end tests have passedPassed tests (80)Click to expand
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12097.
However because of MetaMask/eth-sig-util#106 the recoverTypedSignature_v4 from eth-sig-util can return a wrong address from the signature generated by our signTypedData_V4 (if the data uses arrays/structs).