[Profile] Other profile screen UI #8776
Conversation
Pull Request Checklist
|
tbenr
changed the title
Jenkins BuildsClick to see older builds (83)
|
tbenr
force-pushed
the
Other_profile_screen_UI_#8071
branch
from
677d0cd to
08aaa52
Compare
tbenr
force-pushed
the
Other_profile_screen_UI_#8071
branch
from
08aaa52 to
a354322
Compare
|
@tbenr is this still wip? |
|
@flexsurfer yes, need to remove unused files and a couple of other things.. this evening i should finish. |
tbenr
force-pushed
the
Other_profile_screen_UI_#8071
branch
3 times, most recently
from
9accc93 to
58b1e5d
Compare
|
@flexsurfer I think we can start the review. |
tbenr
force-pushed
the
Other_profile_screen_UI_#8071
branch
from
58b1e5d to
2076fc1
Compare
src/status_im/contact/core.cljs
Outdated
| [{:keys [db] :as cofx} public-key] | ||
| (fx/merge cofx | ||
| {:db (update db :contacts/contacts dissoc public-key) | ||
| :data-store/tx [(contacts-store/delete-contact-tx public-key)]})) |
There was a problem hiding this comment.
i believe we don't use :data-store/tx for contacts anymore @cammellos could you assist, please?
There was a problem hiding this comment.
for sure we don't, the question is do we have a "shhext_deleteContact" rpc method to replace it? @cammellos
if we don't I'd say just add a TODO here that says the contact is not actually remove, because this is a UI PR and there is no point blocking it waiting for a core feature. Remove that :data-store/tx it the delete-contact-tx function won't exist once you rebase anyway.
There was a problem hiding this comment.
should we remove the contact completely (needs a new endpoint in status-go), or is it enough to remove the contacts/added tag (does not need a new endpoint)?
If we delete it completely, it will come back (maybe not in the list if we are filtering by contact/added tag), next contact update, so not sure how useful it is, but I don't have much context on this task.
There was a problem hiding this comment.
I suppose we just want to remove contacts/added, it removes the user from the contact list right?
There was a problem hiding this comment.
Not sure about that, I would guess so as it should only show contacts that we added.
Essentially we can just remove the contact/added tag and call save-contact in status-im.data-store.contacts
There was a problem hiding this comment.
@cammellos @yenda take a look to the latest push
|
|
||
| (defn- contact->details | ||
| "prepare a sequence of datails from a given contact" | ||
| [contact] |
There was a problem hiding this comment.
@flexsurfer the function should "prepare" a list of details (accounts\wallet) from the current contact. Since i don't know how will actually wallet\accounts be stored in db for a given contact, I prepared a function for the purpose.
Currently it just create an array with current account.
There was a problem hiding this comment.
contact will always be a map, wallet and accounts will be part of it. I'd just remove this fn a use contact directly
There was a problem hiding this comment.
@yenda I missed this comment, later this afternoon i'll remove it.
tbenr
force-pushed
the
Other_profile_screen_UI_#8071
branch
from
2076fc1 to
36ff826
Compare
|
@flexsurfer i added wrong (long name): ok (short name): the accessory goes off-screen. Any hint? |
tbenr
force-pushed
the
Other_profile_screen_UI_#8071
branch
from
36ff826 to
43db7dd
Compare
|
I also implemented sheet for "block this user" |
@tbenr let me chime in here. As a critical part of #8070 I am adjusting the
I am almost done with the PR for #8070 and will be pushing it soon |
|
Sorry for that, this time was about permissions due to branch not being in the repo. |
tbenr
force-pushed
the
Other_profile_screen_UI_#8071
branch
from
660c9bd to
ae60247
Compare
|
@flexsurfer @churik @Serhy can we try to test again? |
|
@tbenr apologies for any delay - we're on our team offsite in Istanbul this week so will be responding a bit more slowly than usual. Would love to get this one finalized so we can pay you! Will see if we can prioritize it. |
|
Merging this will also help me with PRs I'm working on 🙌 :) |
|
@tbenr sorry for delay, we all on offsite in Istanbul. |
91% of end-end tests have passedFailed tests (4)Click to expand
Passed tests (42)Click to expand |
|
@tbenr two small issues:
Thank you for hard work! |
|
@churik damn :) i'll fix it when back home... thanks for patient |
tbenr
force-pushed
the
Other_profile_screen_UI_#8071
branch
from
ae60247 to
e4660e8
Compare
|
@churik MAYBE HOPEFULLY this is the last time :) |
50% of end-end tests have passedFailed tests (1)Click to expand
Passed tests (1) |
|
@tbenr :) And I believe we already got confirmation from @errorists that he is OK with new view. |
|
@churik ahh ok I reactivate it once back home. No problems:) |
tbenr
force-pushed
the
Other_profile_screen_UI_#8071
branch
from
e4660e8 to
dc2625f
Compare
|
@churik reenabled sheet on block, rebased too. |
|
@tbenr many thanks for your patience! |
Signed-off-by: yenda <[email protected]>
yenda
force-pushed
the
Other_profile_screen_UI_#8071
branch
from
dc2625f to
f707601
Compare
fixes: #8071
after #8069 as been merged I integrate my part with the work from the great @bitsikka
regarding large_toolbar:
large_toolbar, decoupling styles too.large_toolbarimplementation on flat-list's on-scroll eventsthen i implemented the "other profile". It is still not supporting multiple details (main chat account is listed) but the basis for listing multiple accounts\wallets is there.
status: ready