fix errors

ingest/processors/effects_test.go

@@ -3489,7 +3489,6 @@ func TestInvokeHostFunctionEffects(t *testing.T) {
 
 	admin := randAddr()
 	asset := xdr.MustNewCreditAsset("TESTER", admin)
-	nativeAsset := xdr.MustNewNativeAsset()
 	from, to := randAddr(), randAddr()
 	fromContractBytes, toContractBytes := xdr.Hash{}, xdr.Hash{1}
 	fromContract := strkey.MustEncode(strkey.VersionByteContract, fromContractBytes[:])
@@ -3691,7 +3690,7 @@ func TestInvokeHostFunctionEffects(t *testing.T) {
 			},
 		}, {
 			desc:      "transfer native",
-			asset:     nativeAsset,
+			asset:     xdr.MustNewNativeAsset(),
 			eventType: contractevents.EventTypeTransfer,
 			expected: []EffectOutput{
 				{

ingest/processors/ledger.go

@@ -57,9 +57,11 @@ func TransformLedger(inputLedger historyarchive.Ledger, lcm xdr.LedgerCloseMeta)
 
 	var outputSorobanFeeWrite1Kb int64
 	var outputTotalByteSizeOfBucketList uint64
+
 	lcmV1, ok := lcm.GetV1()
 	if ok {
-		extV1, ok := lcmV1.Ext.GetV1()
+		var extV1 xdr.LedgerCloseMetaExtV1
+		extV1, ok = lcmV1.Ext.GetV1()
 		if ok {
 			outputSorobanFeeWrite1Kb = int64(extV1.SorobanFeeWrite1Kb)
 		}

ingest/processors/operation.go

@@ -38,7 +38,8 @@ func TransformOperation(operation xdr.Operation, operationIndex int32, transacti
 
 	var outputSourceAccountMuxed null.String
 	if sourceAccount.Type == xdr.CryptoKeyTypeKeyTypeMuxedEd25519 {
-		muxedAddress, err := sourceAccount.GetAddress()
+		var muxedAddress string
+		muxedAddress, err = sourceAccount.GetAddress()
 		if err != nil {
 			return OperationOutput{}, err
 		}
@@ -961,7 +962,7 @@ func extractOperationDetails(operation xdr.Operation, transaction ingest.LedgerT
 		details["reserve_a_deposit_amount"] = depositA
 
 		//Process ReserveB Details
-		if err := addAssetDetailsToOperationDetails(details, assetB, "reserve_b"); err != nil {
+		if err = addAssetDetailsToOperationDetails(details, assetB, "reserve_b"); err != nil {
 			return details, err
 		}
 		details["reserve_b_max_amount"] = ConvertStroopValueToReal(op.MaxAmountB)
@@ -971,10 +972,10 @@ func extractOperationDetails(operation xdr.Operation, transaction ingest.LedgerT
 		}
 		details["reserve_b_deposit_amount"] = depositB
 
-		if err := addPriceDetails(details, op.MinPrice, "min"); err != nil {
+		if err = addPriceDetails(details, op.MinPrice, "min"); err != nil {
 			return details, err
 		}
-		if err := addPriceDetails(details, op.MaxPrice, "max"); err != nil {
+		if err = addPriceDetails(details, op.MaxPrice, "max"); err != nil {
 			return details, err
 		}
 

ingest/processors/trade.go

@@ -172,11 +172,13 @@ func extractClaimedOffers(operationResults []xdr.OperationResult, operationIndex
 	switch operationType {
 	case xdr.OperationTypeManageBuyOffer:
 		var buyOfferResult xdr.ManageBuyOfferResult
+		var success xdr.ManageOfferSuccessResult
+
 		if buyOfferResult, ok = operationTr.GetManageBuyOfferResult(); !ok {
 			err = fmt.Errorf("could not get ManageBuyOfferResult for operation at index %d", operationIndex)
 			return
 		}
-		if success, ok := buyOfferResult.GetSuccess(); ok {
+		if success, ok = buyOfferResult.GetSuccess(); ok {
 			claimedOffers = success.OffersClaimed
 			BuyingOffer = success.Offer.Offer
 			return
@@ -186,12 +188,13 @@ func extractClaimedOffers(operationResults []xdr.OperationResult, operationIndex
 
 	case xdr.OperationTypeManageSellOffer:
 		var sellOfferResult xdr.ManageSellOfferResult
+		var success xdr.ManageOfferSuccessResult
 		if sellOfferResult, ok = operationTr.GetManageSellOfferResult(); !ok {
 			err = fmt.Errorf("could not get ManageSellOfferResult for operation at index %d", operationIndex)
 			return
 		}
 
-		if success, ok := sellOfferResult.GetSuccess(); ok {
+		if success, ok = sellOfferResult.GetSuccess(); ok {
 			claimedOffers = success.OffersClaimed
 			BuyingOffer = success.Offer.Offer
 			return
@@ -216,13 +219,15 @@ func extractClaimedOffers(operationResults []xdr.OperationResult, operationIndex
 
 	case xdr.OperationTypePathPaymentStrictSend:
 		var pathSendResult xdr.PathPaymentStrictSendResult
+		var success xdr.PathPaymentStrictSendResultSuccess
+
 		sellerIsExact = null.BoolFrom(false)
 		if pathSendResult, ok = operationTr.GetPathPaymentStrictSendResult(); !ok {
 			err = fmt.Errorf("could not get PathPaymentStrictSendResult for operation at index %d", operationIndex)
 			return
 		}
 
-		success, ok := pathSendResult.GetSuccess()
+		success, ok = pathSendResult.GetSuccess()
 		if ok {
 			claimedOffers = success.Offers
 			return
@@ -262,7 +267,8 @@ func findTradeSellPrice(t ingest.LedgerTransaction, operationIndex int32, trade
 	if err := key.SetOffer(trade.SellerId(), uint64(trade.OfferId())); err != nil {
 		return 0, 0, errors.Wrap(err, "Could not create offer ledger key")
 	}
-	change, err := findLatestOperationChange(t, operationIndex, key)
+	var change ingest.Change
+	change, err = findLatestOperationChange(t, operationIndex, key)
 	if err != nil {
 		return 0, 0, errors.Wrap(err, "could not find change for trade offer")
 	}
@@ -281,7 +287,8 @@ func findLatestOperationChange(t ingest.LedgerTransaction, operationIndex int32,
 	for i := len(changes) - 1; i >= 0; i-- {
 		change = changes[i]
 		if change.Pre != nil {
-			preKey, err := change.Pre.LedgerKey()
+			var preKey xdr.LedgerKey
+			preKey, err = change.Pre.LedgerKey()
 			if err != nil {
 				return ingest.Change{}, errors.Wrap(err, "could not determine ledger key for change")
 
@@ -300,7 +307,8 @@ func findPoolFee(t ingest.LedgerTransaction, operationIndex int32, poolID xdr.Po
 	if err := key.SetLiquidityPool(poolID); err != nil {
 		return 0, errors.Wrap(err, "Could not create liquidity pool ledger key")
 	}
-	change, err := findLatestOperationChange(t, operationIndex, key)
+	var change ingest.Change
+	change, err = findLatestOperationChange(t, operationIndex, key)
 	if err != nil {
 		return 0, errors.Wrap(err, "could not find change for liquidity pool")
 	}