Code

Feat: add stellar ledger as signer#1627

Code

Open

willemneal wants to merge 118 commits intomainstellar/stellar-cli:mainfrom feat/add_stellar_ledgerstellar/stellar-cli:feat/add_stellar_ledgerCopy head branch name to clipboard

+1,579-633

Commits

Commits on Sep 25, 2024

• feat: initial ledger signer

  willemneal

  committed
  2083a7a

  Copy full SHA for 2083a7a

Commits on Oct 7, 2024

• Merge remote-tracking branch 'origin/main' into feat/add_stellar_ledger

  willemneal

  committed
  aee08f8

  Copy full SHA for aee08f8

Commits on Oct 21, 2024

• Merge branch 'main' into feat/add_stellar_ledger

  willemneal

  authored
  b02ffc2

  Copy full SHA for b02ffc2

• fix: add arg

  willemneal

  committed
  a67f587

  Copy full SHA for a67f587

Commits on Nov 1, 2024

• Merge remote-tracking branch 'origin/main' into feat/add_stellar_ledger

  willemneal

  committed
  70e58b0

  Copy full SHA for 70e58b0

• feat: add ledger key name for lookup and reference as source account

  willemneal

  committed
  0369e05

  Copy full SHA for 0369e05

• Merge remote-tracking branch 'origin/main' into feat/add_stellar_ledger

  willemneal

  committed
  91a5f2b

  Copy full SHA for 91a5f2b

Commits on Nov 2, 2024

• Merge remote-tracking branch 'origin/main' into feat/add_stellar_ledger

  willemneal

  committed
  6a4986e

  Copy full SHA for 6a4986e

Commits on Nov 5, 2024

• Merge remote-tracking branch 'origin/main' into feat/add_stellar_ledger

  willemneal

  committed
  efd2948

  Copy full SHA for efd2948

• Merge remote-tracking branch 'origin/main' into feat/add_stellar_ledger

  willemneal

  committed
  518e591

  Copy full SHA for 518e591

Commits on Nov 11, 2024

• Merge branch 'main' into feat/add_stellar_ledger

  willemneal

  authored
  1fa59d8

  Copy full SHA for 1fa59d8

Commits on Nov 14, 2024

• Merge branch 'main' into feat/add_stellar_ledger

  willemneal

  authored
  a0055a9

  Copy full SHA for a0055a9

Commits on Nov 16, 2024

• Merge branch 'main' into feat/add_stellar_ledger

  willemneal

  authored
  5755990

  Copy full SHA for 5755990

Commits on Nov 18, 2024

• Merge remote-tracking branch 'origin/main' into feat/add_stellar_ledger

  willemneal

  committed
  0aaf7c5

  Copy full SHA for 0aaf7c5

• Merge remote-tracking branch 'origin/main' into feat/add_stellar_ledger

  willemneal

  committed
  8799cd0

  Copy full SHA for 8799cd0

• feat(stellar-ledger): make test utilties public

  willemneal

  committed
  98b0100

  Copy full SHA for 98b0100

Commits on Nov 19, 2024

• fix: add first proper test using ledger and CLI

  willemneal

  committed
  37f302d

  Copy full SHA for 37f302d

• Merge remote-tracking branch 'origin/main' into feat/add_stellar_ledger

  willemneal

  committed
  09eff2f

  Copy full SHA for 09eff2f

• fix: actually test in CI

  willemneal

  committed
  4680b96

  Copy full SHA for 4680b96

Commits on Nov 29, 2024

• feat: Add new Key type; allowing public keys to be named keys

  Show description for d33a9fc
  

  willemneal

  authored and

  gitbutler-client

  committed
  d33a9fc

  Copy full SHA for d33a9fc

• fix: lookup first before parsing raw key

  

  willemneal

  authored and

  gitbutler-client

  committed
  2aec046

  Copy full SHA for 2aec046

• fix: docs

  

  willemneal

  authored and

  gitbutler-client

  committed
  52bd5e8

  Copy full SHA for 52bd5e8

• fix: clippy

  

  willemneal

  authored and

  gitbutler-client

  committed
  8f96343

  Copy full SHA for 8f96343

• feat: update tx new commands to use Address type

  Show description for 0cc57fe
  

  willemneal

  authored and

  gitbutler-client

  committed
  0cc57fe

  Copy full SHA for 0cc57fe

• fix: rebase issue

  

  willemneal

  authored and

  gitbutler-client

  committed
  31cde54

  Copy full SHA for 31cde54

Commits on Nov 30, 2024

• Merge branch 'main' into feat/muxed_keys

  willemneal

  authored
  e5f0e5d

  Copy full SHA for e5f0e5d

Commits on Dec 2, 2024

• Update cmd/soroban-cli/src/config/key.rs

  Show description for a86a98f
  

  willemneal

  and

  leighmcculloch

  authored
  a86a98f

  Copy full SHA for a86a98f

• Merge branch 'main' into feat/muxed_keys

  willemneal

  authored
  a64aae5

  Copy full SHA for a64aae5

• fix: PR review

  

  willemneal

  authored and

  gitbutler-client

  committed
  b36db49

  Copy full SHA for b36db49

• feat: initial work into system keychain

  

  willemneal

  authored and

  elizabethengelman

  committed
  8c06970

  Copy full SHA for 8c06970

• chore: clean up

  

  willemneal

  authored and

  elizabethengelman

  committed
  883cb8c

  Copy full SHA for 883cb8c

• Add KeyName struct in address

  elizabethengelman

  committed
  eb70734

  Copy full SHA for eb70734

• Add Secret::Keychain

  elizabethengelman

  committed
  d4e2500

  Copy full SHA for d4e2500

• keys generate: allow for generating keys that are stored in keychain

  elizabethengelman

  committed
  3ee20b8

  Copy full SHA for 3ee20b8

• keys generate: Namespace keychain entry to identity name

  elizabethengelman

  committed
  1a24c00

  Copy full SHA for 1a24c00

• keys generate: don't allow 'keychain:' as a key name

  elizabethengelman

  committed
  4a0c900

  Copy full SHA for 4a0c900

• keys address: use keychain entry in secret to get the pub key

  elizabethengelman

  committed
  755c318

  Copy full SHA for 755c318

• tx sign: allow a keychain identity sign a tx

  elizabethengelman

  committed
  dd07bf7

  Copy full SHA for dd07bf7

• Cleanup

  elizabethengelman

  committed
  f042d19

  Copy full SHA for f042d19

• Use keyring mock for generate tests

  elizabethengelman

  committed
  9cf5916

  Copy full SHA for 9cf5916

• Refactor keyring: add keyring entry as StellarEntry field

  Show description for cd515d3
  elizabethengelman

  committed
  cd515d3

  Copy full SHA for cd515d3

• Add tests for keyring

  elizabethengelman

  committed
  276558d

  Copy full SHA for 276558d

• Update config/secret tests

  elizabethengelman

  committed
  20c651b

  Copy full SHA for 20c651b

• Cleanup

  elizabethengelman

  committed
  66d1bfc

  Copy full SHA for 66d1bfc

• Rename keychain arg to secure_store in generate

  elizabethengelman

  committed
  8b9763e

  Copy full SHA for 8b9763e

• Rename Secret::Keychain to Secret::SecureStore

  elizabethengelman

  committed
  fdefa2a

  Copy full SHA for fdefa2a

• Rename SignerKind::Keychain to SignerKind::SecureStore

  elizabethengelman

  committed
  36559ea

  Copy full SHA for 36559ea

• Use print for new fns in generate

  elizabethengelman

  committed
  f98b709

  Copy full SHA for f98b709

• Return error when trying to get Secure Store secret

  elizabethengelman

  committed
  0f3106b

  Copy full SHA for 0f3106b

• Cleanup tests

  elizabethengelman

  committed
  e120595

  Copy full SHA for e120595

• Merge branch 'main' into feat/os_keychain

  elizabethengelman

  authored
  c4d6f99

  Copy full SHA for c4d6f99

Commits on Dec 3, 2024

• Merge branch 'main' into feat/os_keychain

  elizabethengelman

  authored
  c7e2cbc

  Copy full SHA for c7e2cbc

• Install libdbus for rpc-tests and bindings-ts workflows

  Show description for 57ba3a4
  elizabethengelman

  committed
  57ba3a4

  Copy full SHA for 57ba3a4

• Update generated docs

  elizabethengelman

  committed
  0814e4b

  Copy full SHA for 0814e4b

• Install libdbus for binaries workflow when target aarch64-unknown-linux-gnu

  elizabethengelman

  committed
  74fa05b

  Copy full SHA for 74fa05b

• Clippy

  elizabethengelman

  committed
  7ff1f6a

  Copy full SHA for 7ff1f6a

• Install libdbus for rust workflow

  elizabethengelman

  committed
  f263d8d

  Copy full SHA for f263d8d

• Install libdbus-1-dev in binaries workflow for build step

  elizabethengelman

  committed
  e2b7342

  Copy full SHA for e2b7342

• Merge branch 'main' into feat/muxed_keys

  willemneal

  authored
  f952c10

  Copy full SHA for f952c10

• Impl Display for KeyName

  Show description for dabbb27
  elizabethengelman

  committed
  dabbb27

  Copy full SHA for dabbb27

• fix: fix tests

  willemneal

  committed
  567e2ab

  Copy full SHA for 567e2ab

• Merge remote-tracking branch 'origin/main' into feat/add_stellar_ledger

  willemneal

  committed
  dd1d079

  Copy full SHA for dd1d079

• Use resolve_muxed_account in resolve_secret

  elizabethengelman

  committed
  d9131b4

  Copy full SHA for d9131b4

• Use resolve_muxed_account to get public key

  elizabethengelman

  committed
  3ad6b9b

  Copy full SHA for 3ad6b9b

• Clippy

  elizabethengelman

  committed
  9d02b01

  Copy full SHA for 9d02b01

• Merge branch 'main' into feat/os_keychain

  elizabethengelman

  authored
  4bddd24

  Copy full SHA for 4bddd24

Commits on Dec 4, 2024

• fix: Sign tx hash instead of tx env with keychain

  elizabethengelman

  committed
  a72276d

  Copy full SHA for a72276d

Commits on Dec 5, 2024

• Merge branch 'main' into feat/muxed_keys

  willemneal

  authored
  ed81494

  Copy full SHA for ed81494

• fix: fmt

  

  willemneal

  authored and

  gitbutler-client

  committed
  9226b1b

  Copy full SHA for 9226b1b

• fix: update to work with op add

  

  willemneal

  authored and

  gitbutler-client

  committed
  3a25564

  Copy full SHA for 3a25564

• fix: simplify op::add::args::Args

  Show description for 5f55e7c
  

  willemneal

  authored and

  gitbutler-client

  committed
  5f55e7c

  Copy full SHA for 5f55e7c

• fix: remove untagged and use rename to keep same serialized output

  

  willemneal

  authored and

  gitbutler-client

  committed
  0e7f08f

  Copy full SHA for 0e7f08f

• fix: docs and clippy in tests

  

  willemneal

  authored and

  gitbutler-client

  committed
  aa8bb16

  Copy full SHA for aa8bb16

• Merge branch 'main' into feat/os_keychain

  elizabethengelman

  authored
  65284cc

  Copy full SHA for 65284cc

Commits on Dec 9, 2024

• Merge remote-tracking branch 'origin/main' into feat/add_stellar_ledger

  willemneal

  committed
  efa4f3a

  Copy full SHA for efa4f3a

• fix: use different contracts for each test

  willemneal

  committed
  7537edb

  Copy full SHA for 7537edb

• fix: use salt for sim test and separate CI tests

  willemneal

  committed
  2d22fb4

  Copy full SHA for 2d22fb4

• fix: clippy

  willemneal

  committed
  a1c654b

  Copy full SHA for a1c654b

• fix: reuse container for ledger tests

  willemneal

  committed
  a04ab20

  Copy full SHA for a04ab20

• Merge branch 'main' into feat/add_stellar_ledger

  willemneal

  authored
  4291ad1

  Copy full SHA for 4291ad1

• Merge branch 'main' into feat/os_keychain

  elizabethengelman

  authored
  e9f86e7

  Copy full SHA for e9f86e7

• Remove unused bin/secret

  elizabethengelman

  committed
  4288630

  Copy full SHA for 4288630

Commits on Dec 10, 2024

• fix: clippy and run each test independently

  willemneal

  committed
  6143b84

  Copy full SHA for 6143b84

• fix: run each ledger test by themselves

  willemneal

  committed
  9a13673

  Copy full SHA for 9a13673

Commits on Dec 11, 2024

• fix: separate into separate job

  willemneal

  committed
  a210205

  Copy full SHA for a210205

Commits on Dec 12, 2024

• Merge branch 'main' into feat/os_keychain

  elizabethengelman

  authored
  6661b42

  Copy full SHA for 6661b42

Commits on Dec 13, 2024

• Merge branch 'main' into feat/os_keychain

  elizabethengelman

  authored
  b2120d2

  Copy full SHA for b2120d2

• Apply suggestions from code review

  Show description for 64cd37b
  

  willemneal

  and

  elizabethengelman

  authored
  64cd37b

  Copy full SHA for 64cd37b

• Merge branch 'main' into feat/muxed_keys

  willemneal

  authored
  732e7f4

  Copy full SHA for 732e7f4

• Update cmd/soroban-cli/src/config/locator.rs

  Show description for d4ba93d
  

  willemneal

  and

  elizabethengelman

  authored
  d4ba93d

  Copy full SHA for d4ba93d

• fix: refactor with renames from PR

  willemneal

  committed
  318f579

  Copy full SHA for 318f579

• fix: build local transaction to test valid signature instead of relying on RPC

  willemneal

  committed
  cb3f499

  Copy full SHA for cb3f499

• Merge remote-tracking branch 'origin/main' into feat/add_stellar_ledger

  willemneal

  committed
  75df1cb

  Copy full SHA for 75df1cb

Commits on Dec 16, 2024

• Merge remote-tracking branch 'origin/main' into feat/add_stellar_ledger

  willemneal

  committed
  c9456fe

  Copy full SHA for c9456fe

• fix: split tests to different hd_pahs

  willemneal

  committed
  f2d8fe7

  Copy full SHA for f2d8fe7

• Merge branch 'main' into feat/muxed_keys

  willemneal

  authored
  60c9d49

  Copy full SHA for 60c9d49

• fix: CI install needed deps

  willemneal

  committed
  6212d31

  Copy full SHA for 6212d31

Commits on Dec 17, 2024

• Merge branch 'main' into feat/os_keychain

  elizabethengelman

  authored
  24e7b59

  Copy full SHA for 24e7b59

Commits on Dec 18, 2024

• Merge branch 'main' into feat/os_keychain

  elizabethengelman

  authored
  cfdb324

  Copy full SHA for cfdb324

Commits on Dec 19, 2024

• Merge branch 'main' into feat/os_keychain

  willemneal

  authored
  8e158a1

  Copy full SHA for 8e158a1

Commits on Dec 20, 2024

• Merge remote-tracking branch 'origin/main' into feat/muxed_keys

  willemneal

  committed
  d776f2d

  Copy full SHA for d776f2d

• Merge remote-tracking branch 'origin/main' into feat/muxed_keys

  willemneal

  committed
  06932dc

  Copy full SHA for 06932dc

• Merge remote-tracking branch 'origin/main' into feat/os_keychain

  willemneal

  committed
  2241352

  Copy full SHA for 2241352

• Merge remote-tracking branch 'origin/main' into feat/os_keychain

  elizabethengelman

  committed
  03b84e8

  Copy full SHA for 03b84e8

• Fix after merging with main

  elizabethengelman

  committed
  24269ce

  Copy full SHA for 24269ce

• Apply suggestion from code review

  Show description for e95fa3a
  

  elizabethengelman

  and

  willemneal

  authored
  e95fa3a

  Copy full SHA for e95fa3a

Commits on Dec 23, 2024

• Limit key name length

  elizabethengelman

  committed
  95d8b32

  Copy full SHA for 95d8b32

• Update public_key to work with secure storage keys

  elizabethengelman

  committed
  01c8753

  Copy full SHA for 01c8753

Commits on Jan 6, 2025

• Merge remote-tracking branch 'origin/main' into feat/os_keychain

  willemneal

  committed
  6404da6

  Copy full SHA for 6404da6

• fix(address): remove private key function & use unresolved Address

  Show description for 085317f
  willemneal

  committed
  085317f

  Copy full SHA for 085317f

Commits on Jan 7, 2025

• feat: store seedphrase instead of private key

  Show description for aecc5ac
  willemneal

  committed
  aecc5ac

  Copy full SHA for aecc5ac

• fix: clean up

  willemneal

  committed
  63f247e

  Copy full SHA for 63f247e

• Merge branch 'feat/os_keychain' into feat/muxed_keys

  willemneal

  committed
  73eead7

  Copy full SHA for 73eead7

Commits on Jan 8, 2025

• Merge branch 'feat/os_keychain' into feat/add_stellar_ledger

  willemneal

  committed
  2a422b8

  Copy full SHA for 2a422b8

Commits on Jan 9, 2025

• Merge branch 'main' into feat/muxed_keys

  elizabethengelman

  committed
  c305d9d

  Copy full SHA for c305d9d

• fix: wait to lookup muxed account

  willemneal

  committed
  ed797e0

  Copy full SHA for ed797e0

• Merge branch 'main' into feat/muxed_keys

  willemneal

  committed
  70240b2

  Copy full SHA for 70240b2

Commits on Jan 10, 2025

• Merge branch 'feat/muxed_keys' into feat/add_stellar_ledger

  willemneal

  committed
  fb02c33

  Copy full SHA for fb02c33