Interface::run returns a Cow<'a> #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed `Interface::run` to return a `Cow` with the lifetime of the borrowed slice of strings. The `Owned` case occurs when the search does not match anything. In that case, the search string is taken out of the `Interface` and replaced by an empty string. Using a `Cow` with the lifetime of the given strings allows to drop the `Interface` struct after a run, without needing to clone the returned `&str` to keep the result. It also allows the caller to know whether the result is from the given list, or comes from a search that had no match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently used this crate as a lib for a personal project, and I really appreciated it!
I once tried to simply call
Interface::new(&stuff).run()and got errors with lifetime. Looking further I found out that the result ofrunis not a reference with the lifetime ofstuff, because it may return a reference to the search string.So I changed the return type of
runand the functionresultto take the search string in the case of no matches. This allows droppingInterfaceand keep the result.This is a breaking change to the API, as the return type and lifetime are changed, and
runnow clear the search string if it did not match.