Removing use of boost::variant and optional from stlab now that it has moved to C++17 #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-parent
requested changes
Oct 25, 2023
| @@ -150,7 +150,7 @@ string(const char * initial_value) { | |||
|
|
|||
| How can we work with the cases in the above example? We obviously can't use the empty constructor and we can't use the other constructor as we don't want to waste that memory. | |||
|
|
|||
| This is where optional shines. It is shipping as standard in C++17 but is also available as `boost::optional`. | |||
| This is where optional shines. It is shipping as standard in C++17 but is also available as `std::optional`. | |||
There was a problem hiding this comment.
This is from a blog post - it should remain boost::optional.
thinlang
commented
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.