-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MOBILESDK-2682] Display “default” badge on default card in horizontal mode #9876
base: master
Are you sure you want to change the base?
Conversation
Diffuse output:
APK
|
paymentsheet/src/main/java/com/stripe/android/paymentsheet/ui/SavedPaymentMethodTab.kt
Show resolved
Hide resolved
@@ -21,14 +22,15 @@ class PaymentOptionTest { | |||
val composeTestRule = createComposeRule() | |||
|
|||
@Test | |||
fun `Turns card label into screen reader-friendly text`() { | |||
fun `SavedPaymentMethodTab created corrected`() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test name has a grammatical error - created corrected
should be created correctly
to properly describe what is being tested.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Summary
Added default badge to horizontal mode screens
updated tests
Motivation
MOBILESDK-2682
MOBILESDK-2931
Testing
Changelog
N.A.