-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link Create Payment Method VM #9878
Conversation
Diffuse output:
APK
|
paymentsheet/src/main/java/com/stripe/android/link/ui/paymentmenthod/PaymentMethodState.kt
Show resolved
Hide resolved
paymentsheet/src/main/java/com/stripe/android/paymentsheet/analytics/DefaultEventReporter.kt
Show resolved
Hide resolved
...sheet/src/main/java/com/stripe/android/lpmfoundations/paymentmethod/PaymentMethodMetadata.kt
Outdated
Show resolved
Hide resolved
...ntsheet/src/test/java/com/stripe/android/link/ui/paymentmethod/PaymentMethodViewModelTest.kt
Outdated
Show resolved
Hide resolved
...ntsheet/src/test/java/com/stripe/android/link/ui/paymentmethod/PaymentMethodViewModelTest.kt
Show resolved
Hide resolved
e67de18
to
0f159e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the only use of this fake is in PaymentMethodViewModelTest, I think you could either:
- actually implement the functions in this fake with the implementation that's being used in PaymentMethodViewModelTest
- just implement this fake directly in PaymentMethodViewModelTest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just thinking that if this specific fake implementation isn't being used, we don't necessarily need it. And it's ok to have a general fake implementation that works
b9512a3
to
746555a
Compare
297ed6f
to
02b8ec5
Compare
Summary
ViewModel for creating card payment method for Link. Bank account payment method is out of scope.
Motivation
JIRA
Testing
Screenshots (There is no UI in this PR)
Screen.Recording.2025-01-08.at.4.58.05.PM.mov
Changelog