Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Create Payment Method VM #9878

Merged
merged 6 commits into from
Jan 14, 2025
Merged

Conversation

toluo-stripe
Copy link
Contributor

@toluo-stripe toluo-stripe commented Jan 8, 2025

Summary

ViewModel for creating card payment method for Link. Bank account payment method is out of scope.

Motivation

JIRA

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots (There is no UI in this PR)

Screen.Recording.2025-01-08.at.4.58.05.PM.mov

Changelog

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.6 KiB │ 302.6 KiB │  0 B │ 456.7 KiB │ 456.7 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.2 KiB │   7.2 KiB │  0 B │   6.9 KiB │   6.9 KiB │  0 B 
    other │  90.4 KiB │  90.4 KiB │ +4 B │ 170.7 KiB │ 170.7 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ +4 B │  21.5 MiB │  21.5 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 19982 │ 19982 │ 0 (+0 -0) 
   types │  6194 │  6194 │ 0 (+0 -0) 
 classes │  4985 │  4985 │ 0 (+0 -0) 
 methods │ 29820 │ 29820 │ 0 (+0 -0) 
  fields │ 17539 │ 17539 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3624 │ 3624 │  0
APK
   compressed    │   uncompressed   │                                           
──────────┬──────┼───────────┬──────┤                                           
 size     │ diff │ size      │ diff │ path                                      
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 28.5 KiB │ +9 B │  63.1 KiB │  0 B │ ∆ META-INF/CERT.SF                        
 25.4 KiB │ -3 B │    63 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
    271 B │ -1 B │     120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
  1.2 KiB │ -1 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 55.3 KiB │ +4 B │ 127.4 KiB │  0 B │ (total)

@toluo-stripe toluo-stripe marked this pull request as ready for review January 8, 2025 22:02
@toluo-stripe toluo-stripe requested review from a team as code owners January 8, 2025 22:02
@toluo-stripe toluo-stripe force-pushed the tolu/link/payment_method_vm branch from e67de18 to 0f159e6 Compare January 10, 2025 21:13
amk-stripe
amk-stripe previously approved these changes Jan 13, 2025
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the only use of this fake is in PaymentMethodViewModelTest, I think you could either:

  • actually implement the functions in this fake with the implementation that's being used in PaymentMethodViewModelTest
  • just implement this fake directly in PaymentMethodViewModelTest

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just thinking that if this specific fake implementation isn't being used, we don't necessarily need it. And it's ok to have a general fake implementation that works

@toluo-stripe toluo-stripe force-pushed the tolu/link/payment_method_vm branch from 297ed6f to 02b8ec5 Compare January 14, 2025 18:10
@toluo-stripe toluo-stripe merged commit a8b5ca7 into master Jan 14, 2025
13 checks passed
@toluo-stripe toluo-stripe deleted the tolu/link/payment_method_vm branch January 14, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants