Omit usage if empty

stripe · Dec 1, 2023 · b442111 · b442111
1 parent 0455e39
commit b442111
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/lib/stripe/stripe_client.rb b/lib/stripe/stripe_client.rb
@@ -1048,7 +1048,11 @@ def initialize(request_id, request_duration_ms, usage: [])
       end
 
       def payload
-        { request_id: request_id, request_duration_ms: request_duration_ms, usage: usage }
+        ret = { request_id: request_id, request_duration_ms: request_duration_ms}
+        if !usage.nil? && !usage.empty?
+          ret[:usage] = usage
+        end
+        ret
       end
     end
   end

diff --git a/test/stripe/stripe_client_test.rb b/test/stripe/stripe_client_test.rb
@@ -1416,9 +1416,17 @@ class StripeClientTest < Test::Unit::TestCase
         assert(!trace_metrics_header.nil?)
 
         trace_payload = JSON.parse(trace_metrics_header)
+
         assert(trace_payload["last_request_metrics"]["request_id"] == "req_123")
         assert(!trace_payload["last_request_metrics"]["request_duration_ms"].nil?)
         assert(trace_payload["last_request_metrics"]["usage"] == ["save"])
+
+        Stripe::Charge.list
+        trace_payload = JSON.parse(trace_metrics_header)
+        assert(trace_payload["last_request_metrics"]["request_id"] == "req_123")
+        assert(!trace_payload["last_request_metrics"]["request_duration_ms"].nil?)
+        assert(trace_payload["last_request_metrics"]["usage"].nil?)
+
       end
     end