Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration options for hardcoded values #111

Merged
merged 3 commits into from
Jul 6, 2024
Merged

Configuration options for hardcoded values #111

merged 3 commits into from
Jul 6, 2024

Conversation

nstogner
Copy link
Contributor

@nstogner nstogner commented Jul 6, 2024 •
edited
Loading

  • Add MESSENGER_ERROR_MAX_BACKOFF config env var
  • Add AUTOSCALING_TIME_WINDOW config env var
  • Add AUTOSCALING_INTERVAL config env var

For time window calc see: https://go.dev/play/p/b2GdRzMJPUb

@nstogner
Copy link
Contributor Author

nstogner commented Jul 6, 2024

Fixes #109

@nstogner
Copy link
Contributor Author

nstogner commented Jul 6, 2024

Fixes #108

@nstogner nstogner changed the title Make max messenger error backoff configurable Configuration options for hardcoded values Jul 6, 2024
@samos123
Copy link
Contributor

samos123 commented Jul 6, 2024

Is setting MESSENGER_ERROR_MAX_BACKOFF=0s the same as turning of the backoff? Would that work?

@samos123 samos123 merged commit 1d8de27 into main Jul 6, 2024
6 checks passed
@samos123 samos123 deleted the more-config-less-hardcoding branch July 6, 2024 06:17
@nstogner
Copy link
Contributor Author

nstogner commented Jul 6, 2024

Yep, that should disable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samos123 samos123 samos123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nstogner @samos123