Fix #67 only leader should do scaling #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samos123
force-pushed
the
refactor-scaler.go
branch
from
12b450f to
2c85ad2
Compare
samos123
changed the title
This reverts commit 2c85ad2.
nstogner
approved these changes
Feb 7, 2024
|
highest priority of test cases is to properly test scale down but couldn't get that to work... I would like some help on that, but will merge this first. I figured better start with some test case than have 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the leader should be responsible for scale up and scale down. The only exception is "AtLeastOne" call in proxy handler. Any other scale ups / scale down should not be allowed in the replicas that are not the leader. That's why UpdateState should not be calling compareScales which can cause scale ups/downs.