Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub action for creating release #81

Merged
merged 1 commit into from
Apr 2, 2024
Merged

GitHub action for creating release #81

merged 1 commit into from
Apr 2, 2024

Conversation

samos123
Copy link
Contributor

No description provided.

@samos123 samos123 requested a review from nstogner February 15, 2024 06:07
nstogner
nstogner reviewed Feb 16, 2024
View reviewed changes
Copy link
Contributor

@nstogner nstogner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this different from the create-release button?

@samos123
Copy link
Contributor Author

So all I need to do is git tag v0.1.0 && git push instead of doing that and then hoping I remember to do clicky clicky button.

@samos123
Copy link
Contributor Author

samos123 commented Apr 1, 2024

@nstogner lets get this merged so our github project shows having releases with change logs whenever i push a new tag. I tested this out in vllm-docker project and it's very convenient.

@samos123
Copy link
Contributor Author

samos123 commented Apr 2, 2024

Merging, can revert if you have a strong opinion against it.

@samos123 samos123 merged commit 7a47423 into main Apr 2, 2024
6 checks passed
@samos123 samos123 deleted the create-gh-release branch April 2, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nstogner nstogner nstogner left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samos123 @nstogner