feat: logup batching (#487)

Co-authored-by: Kevin Jue <[email protected]>
succinctlabs · Apr 11, 2024 · 8d2ad2f · 8d2ad2f
1 parent 3a0d957
commit 8d2ad2f
Show file tree

Hide file tree

Showing 5 changed files with 218 additions and 168 deletions.
diff --git a/core/src/stark/chip.rs b/core/src/stark/chip.rs
@@ -87,14 +87,21 @@ where
     where
         F: PrimeField,
     {
+        let batch_size = self.logup_batch_size();
         generate_permutation_trace(
             &self.sends,
             &self.receives,
             preprocessed,
             main,
             random_elements,
+            batch_size,
         )
     }
+
+    pub fn logup_batch_size(&self) -> usize {
+        // TODO: calculate by log_quotient_degree.
+        2
+    }
 }
 
 impl<F, A> BaseAir<F> for Chip<F, A>
@@ -156,7 +163,8 @@ where
         // Evaluate the execution trace constraints.
         self.air.eval(builder);
         // Evaluate permutation constraints.
-        eval_permutation_constraints(&self.sends, &self.receives, builder);
+        let batch_size = self.logup_batch_size();
+        eval_permutation_constraints(&self.sends, &self.receives, batch_size, builder);
     }
 }