Skip to content

Commit

Permalink
chore: update ssh dependencies to https (#235)
Browse files Browse the repository at this point in the history
Co-authored-by: John Guibas <[email protected]>
  • Loading branch information
jtguibas and John Guibas authored Feb 14, 2024
1 parent 05f9b47 commit f5b475d
Show file tree
Hide file tree
Showing 17 changed files with 259 additions and 260 deletions.
43 changes: 21 additions & 22 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

38 changes: 19 additions & 19 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,22 +15,22 @@ debug = true
debug-assertions = true

[workspace.dependencies]
p3-air = { git = "ssh://git@github.com/succinctlabs/plonky3.git" }
p3-field = { git = "ssh://git@github.com/succinctlabs/plonky3.git" }
p3-commit = { git = "ssh://git@github.com/succinctlabs/plonky3.git" }
p3-matrix = { git = "ssh://git@github.com/succinctlabs/plonky3.git" }
p3-baby-bear = { git = "ssh://git@github.com/succinctlabs/plonky3.git" }
p3-util = { git = "ssh://git@github.com/succinctlabs/plonky3.git" }
p3-challenger = { git = "ssh://git@github.com/succinctlabs/plonky3.git" }
p3-dft = { git = "ssh://git@github.com/succinctlabs/plonky3.git" }
p3-fri = { git = "ssh://git@github.com/succinctlabs/plonky3.git" }
p3-goldilocks = { git = "ssh://git@github.com/succinctlabs/plonky3.git" }
p3-keccak = { git = "ssh://git@github.com/succinctlabs/plonky3.git" }
p3-keccak-air = { git = "ssh://git@github.com/succinctlabs/plonky3.git" }
p3-blake3 = { git = "ssh://git@github.com/succinctlabs/plonky3.git" }
p3-mds = { git = "ssh://git@github.com/succinctlabs/plonky3.git" }
p3-merkle-tree = { git = "ssh://git@github.com/succinctlabs/plonky3.git" }
p3-poseidon2 = { git = "ssh://git@github.com/succinctlabs/plonky3.git" }
p3-symmetric = { git = "ssh://git@github.com/succinctlabs/plonky3.git" }
p3-uni-stark = { git = "ssh://git@github.com/succinctlabs/plonky3.git" }
p3-maybe-rayon = { git = "ssh://git@github.com/succinctlabs/plonky3.git" }
p3-air = { git = "https://github.com/succinctlabs/plonky3.git" }
p3-field = { git = "https://github.com/succinctlabs/plonky3.git" }
p3-commit = { git = "https://github.com/succinctlabs/plonky3.git" }
p3-matrix = { git = "https://github.com/succinctlabs/plonky3.git" }
p3-baby-bear = { git = "https://github.com/succinctlabs/plonky3.git" }
p3-util = { git = "https://github.com/succinctlabs/plonky3.git" }
p3-challenger = { git = "https://github.com/succinctlabs/plonky3.git" }
p3-dft = { git = "https://github.com/succinctlabs/plonky3.git" }
p3-fri = { git = "https://github.com/succinctlabs/plonky3.git" }
p3-goldilocks = { git = "https://github.com/succinctlabs/plonky3.git" }
p3-keccak = { git = "https://github.com/succinctlabs/plonky3.git" }
p3-keccak-air = { git = "https://github.com/succinctlabs/plonky3.git" }
p3-blake3 = { git = "https://github.com/succinctlabs/plonky3.git" }
p3-mds = { git = "https://github.com/succinctlabs/plonky3.git" }
p3-merkle-tree = { git = "https://github.com/succinctlabs/plonky3.git" }
p3-poseidon2 = { git = "https://github.com/succinctlabs/plonky3.git" }
p3-symmetric = { git = "https://github.com/succinctlabs/plonky3.git" }
p3-uni-stark = { git = "https://github.com/succinctlabs/plonky3.git" }
p3-maybe-rayon = { git = "https://github.com/succinctlabs/plonky3.git" }
2 changes: 1 addition & 1 deletion book/generating-proofs/advanced.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ SHARD_SIZE=2097152 RUST_LOG=info RUSTFLAGS='-C target-cpu=native' cargo run --re
Otherwise, make sure to include the "neon" feature when importing `sp1-zkvm` in your `Cargo.toml`:

```toml,noplayground
sp1-core = { git = "ssh://git@github.com/succinctlabs/sp1.git", features = [ "neon" ] }
sp1-core = { git = "https://github.com/succinctlabs/sp1.git", features = [ "neon" ] }
```

## Logging and Tracing Information
Expand Down
2 changes: 1 addition & 1 deletion book/writing-programs/patched-crates.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ cargo update -p ed25519-consensus
If you want to patch with a private repo, you have to use the following adjustment in your `Cargo.toml`:

```toml
ed25519-consensus = { git = "ssh://git@github.com/succinctlabs/ed25519-consensus-private.git" }
ed25519-consensus = { git = "https://github.com/succinctlabs/ed25519-consensus-private.git" }
```
and use the following command to apply the patch (assuming you have your ssh keys setup properly with Github):
```
Expand Down
2 changes: 1 addition & 1 deletion core/src/utils/prove.rs
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ pub(super) mod baby_bear_poseidon2 {
pcs: Pcs,
}

// Implement serialization manually instead of using serde(into) to avoid cloing the config.
/// Implement serialization manually instead of using serde to avoid cloing the config.
impl Serialize for BabyBearPoseidon2 {
fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
where
Expand Down
Loading

0 comments on commit f5b475d

Please sign in to comment.