chore: bump version tag #1946
Merged
chore: bump version tag #1946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crates/cli/src/lib.rs
Outdated
| @@ -7,7 +7,7 @@ use std::process::{Command, Stdio}; | |||
| pub const RUSTUP_TOOLCHAIN_NAME: &str = "succinct"; | |||
|
|
|||
| /// The latest version (github tag) of the toolchain that is supported by our build system. | |||
| pub const LATEST_SUPPORTED_TOOLCHAIN_VERSION_TAG: &str = "v1.82.0"; | |||
| pub const LATEST_SUPPORTED_TOOLCHAIN_VERSION_TAG: &str = "succinct-1.82.0-20.04"; | |||
There was a problem hiding this comment.
Is this correct? What happens on ARM machines for this?
ratankaliani
approved these changes
Jan 17, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -7,7 +7,10 @@ use std::process::{Command, Stdio}; | |||
| pub const RUSTUP_TOOLCHAIN_NAME: &str = "succinct"; | |||
|
|
|||
| /// The latest version (github tag) of the toolchain that is supported by our build system. | |||
| pub const LATEST_SUPPORTED_TOOLCHAIN_VERSION_TAG: &str = "v1.82.0"; | |||
| /// | |||
| /// This tag has suppoert for older x86 libc versions (like the one found in Ubuntu 20.04). | |||
There was a problem hiding this comment.
typos:
Suggested change
| /// This tag has suppoert for older x86 libc versions (like the one found in Ubuntu 20.04). | |
| /// This tag has support for older x86 libc versions (like the one found in Ubuntu 20.04). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.