feat: Allow deserialization of StarkGenericConfig
s
#218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables deserialization of the various
StarkGenericConfig
implementations. In the previous implementation, these types were serialized using theSerializer::serialize_none
function, which was typically reserved forOption
types. Now, these types are serialized asstd::marker::PhantomData<Self>
and deserialized by first deserializing aPhantomData
instance and then dropping the Phantom and returningSelf::new()
.(Note: The
Phantom
deserialization is necessary for correctness, since serializers are allowed to serializePhantomData
into a non-empty byte sequence).