fix: inputs for RSA example #271
Conversation
| // Read an input to the program. | ||
| // | ||
| // Behind the scenes, this compiles down to a custom system call which handles reading inputs | ||
| let pk_der = sp1_zkvm::io::read::<Vec<u8>>(); |
There was a problem hiding this comment.
Does this program actually work? I don't think this should work because the io reader doesn't know how many bytes to actually read, if I'm not mistaken. You can either use read_slice and pass in a mutable slice with a particular length or you can just read a RsaPublicKey if that implements Serde, Deserde
There was a problem hiding this comment.
Well, it does when running in dev mode with SP1Prover::execute(REGEX_IO_ELF, stdin) but when trying with SP1Prover::prove(REGEX_IO_ELF, stdin) it prints the message from the program and gets killed:
I thought it was something related to my machine (Ubuntu 22) because it gets killed too when running the initial RSA example.
because the io reader doesn't know how many bytes to actually read
This was my understanding as well but then it works when String is passed along and String boils down to Vec<u8> 🤔
There was a problem hiding this comment.
I just tested it on a macOS, and I confirm the program works.
| pkcs8::{DecodePrivateKey, DecodePublicKey}, | ||
| RsaPrivateKey, RsaPublicKey, | ||
| }; | ||
| use std::vec; | ||
|
|
||
| /// The ELF we want to execute inside the zkVM. | ||
| const REGEX_IO_ELF: &[u8] = include_bytes!("../../program/elf/riscv32im-succinct-zkvm-elf"); |
There was a problem hiding this comment.
nit: I know this isn't your fault, but do you mind changing this to "RSA_ELF"
|
|
||
| let message = b"Hello world!".to_vec(); | ||
|
|
||
| let signature: Vec<u8> = vec
The RSA example's keys and signature are hardcoded in the program:
sp1/examples/rsa/program/src/main.rs
Lines 18 to 27 in 8ac9e54
That makes this example program look "rigid" by generating an elf file for a specific key and message.
It seems more natural to have those elements in the script as inputs. That allows us to generalize the program and reuse the generated elf file for the verification of any key-message pair.