refactor: introduce a union type for opcode_specific_columns
#310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlubarov
force-pushed
the
union_for_opcode_specific_cols
branch
from
8692909 to
a251df3
Compare
dlubarov
changed the title
opcode_specific_columnsopcode_specific_columns
dlubarov
force-pushed
the
union_for_opcode_specific_cols
branch
from
a251df3 to
9e65fd8
Compare
This may be a bit questionable since union access is unsafe, leading to additional unsafe code. I would argue that that the usual safety concern with union simply doesn't apply here, since all interpretations of the underlying data are simultaneously valid. Still, any use of `unsafe` is not ideal. The use of unions also requires `T: Copy`, but I think that should be fine. On the plus side, `size_of_opcode_specific_columns()` can now be replaced with a simple `size_of()` call, and code that interacts with opcode-specific columns becomes a bit cleaner. Given the pros and cons, this is a tentative suggestion; if you prefer the old style I think that's perfectly reasonable also.
dlubarov
force-pushed
the
union_for_opcode_specific_cols
branch
from
9e65fd8 to
fe78a9e
Compare
|
Thanks for the PR @dlubarov! Taking a look now, sorry we missed this. |
added 3 commits
March 6, 2024 13:08
jtguibas
approved these changes
Mar 6, 2024
jtguibas
pushed a commit
that referenced
this pull request
Mar 29, 2024
Co-authored-by: John Guibas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may be a bit questionable since union access is unsafe, leading to additional unsafe code. I would argue that that the usual safety concern with union simply doesn't apply here, since all interpretations of the underlying data are simultaneously valid. Still, any use of
unsafeis not ideal.The use of unions also requires
T: Copy, but I think that should be fine.On the plus side,
size_of_opcode_specific_columns()can now be replaced with a simplesize_of()call, and code that interacts with opcode-specific columns becomes a bit cleaner.Given the pros and cons, this is a tentative suggestion; if you prefer the old style I think that's perfectly reasonable also.