refactor(breaking): move SP1Prover and SP1Verifier to sp1 crate
#343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ratankaliani
changed the title
SP1Prover and SP1VerifierSP1Prover and SP1Verifier to sp1 crate
ratankaliani
commented
Mar 1, 2024
| }; | ||
| use crate::{utils::BabyBearBlake3, SP1ProofWithIO, SP1Prover, SP1Stdin, SP1Verifier}; | ||
|
|
||
| pub const FIBONACCI_IO_ELF: &[u8] = |
There was a problem hiding this comment.
Note: Didn't want to re-export all of the ELF's from programs::tests as it would slow down compilation time (would force sp1-core to compile all of the ELF's before sp1 could import). Instead, just include the only ELF required by the tests in io.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for remote proving, move
SP1ProverandSP1Verifierintosp1_core. User entrypoints into core should go through thesp1crate, and thesp1-corecrate should not have dependencies on libraries such asreqwest.Note: This change should be accompanied with changes to the documentation, which previously specified importing user-facing dependencies from
sp1_core.