Retry Dimensions pubs query #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwrubel
commented
Jul 16, 2024
test/harvest/test_merge_pubs.py
Outdated
| @@ -138,7 +138,7 @@ def sul_pubs_csv(tmp_path): | |||
|
|
|||
| def test_dimensions_pubs_df(dimensions_pubs_csv): | |||
| lazy_df = merge_pubs.dimensions_pubs_df(dimensions_pubs_csv) | |||
| assert type(lazy_df) == pl.lazyframe.frame.LazyFrame | |||
| assert lazy_df.isinstance(pl.lazyframe.frame.LazyFrame) | |||
There was a problem hiding this comment.
CI runs latest version of Ruff and flagged these linting errors from new rules.
edsu
approved these changes
Jul 16, 2024
edsu
requested changes
Jul 16, 2024
test/harvest/test_merge_pubs.py
Outdated
| @@ -138,7 +138,7 @@ def sul_pubs_csv(tmp_path): | |||
|
|
|||
| def test_dimensions_pubs_df(dimensions_pubs_csv): | |||
| lazy_df = merge_pubs.dimensions_pubs_df(dimensions_pubs_csv) | |||
| assert type(lazy_df) == pl.lazyframe.frame.LazyFrame | |||
| assert lazy_df.isinstance(pl.lazyframe.frame.LazyFrame) | |||
There was a problem hiding this comment.
I think this needs to be isinstance(lazy_df, pl.lazyframe.frame.LazyFrame)?
lwrubel
force-pushed
the
retry-dimensions
branch
from
ff182cc to
0536631
Compare
edsu
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen the
dimensions_harvest_pubstask fail with 502 and 408 errors. Trying to automatically retry several times in those cases.Tested locally running task.