Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic typography styles for common elements #49

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add basic typography styles for common elements #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions styles/header.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,7 @@
}
}

.h1 {
font-size: 2.25rem;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no longer needed since it's the default


a {
--bs-link-hover-decoration: none;
}
.h1 a {
--bs-link-hover-decoration: none;
}
}
62 changes: 62 additions & 0 deletions styles/typography.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,65 @@
--font-family-serif: "Source Serif 4", serif;
--bs-font-sans-serif: "Source Sans 3", "Source Sans Pro";
}

h1, .h1 {
font-size: 2.25rem;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are supposed to keep the responsive text size for screens below 1200px, but I am not 100% sure about this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah – so all of this (except the parts that say "xs" and "xl", maybe?) would be for <= 1200px only?

Copy link
Contributor

@dnoneill dnoneill Sep 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are supposed to do both, i.e.

less than 1200px responsive text sizes with the new variables (i.e. H1 gets calculated with 2.25rem not 2.5rem)

greater than 1200px fixed font where it is 2.25rem not 2.5rem

But honestly this ticket was kind of confusing to me. I think @jcoyne has a better handle than I do.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was my understanding that we would continue to have responsive text sizes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the responsive sizes defined somewhere else? Do I just need to put most of these changes behind a breakpoint?

line-height: 2.375rem;
font-weight: 600;
}

h2, .h2 {
font-size: 1.75rem;
line-height: 2rem;
font-weight: 600;
}

h3, .h3 {
font-size: 1.5rem;
font-weight: 600;
}

h4, .h4 {
font-size: 1.25rem;
font-weight: 600;
}

h5, .h5 {
font-size: 1rem;
font-weight: 600;
}

h6, .h6 {
font-size: 0.9rem;
font-weight: 600;
text-transform: uppercase;
}

dt {
font-size: 1rem;
font-weight: 600;
}

dd {
font-size: 1rem;
font-weight: 400;
}

p {
font-size: 1rem;
font-weight: 400;
}

/* xs */
@media (width < 576px) {
p {
font-size: 0.9rem;
}
}

/* xl */
@media (width >= 1200px) {
p {
font-size: 1.25rem;
}
}