Handle non-successful response from borrowdirect #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbeer
reviewed
Dec 3, 2024
| @@ -25,7 +27,10 @@ def get(path, **) | |||
| end | |||
|
|
|||
| def get_json(path, **) | |||
| parse(get(path, **)) | |||
| parse(check_response(get(path, **))) | |||
| rescue BorrowDirectError => e | |||
There was a problem hiding this comment.
Is the client the right place to suppress this error, or should it be rescued at a higher level? (like, say,
?)I guess I'm worried rescuing the errors this low in the stack could make it harder to debug problems.
There was a problem hiding this comment.
Makes sense. I moved the rescue up to BorrowDirectReshareRequests#reshare_requests.
corylown
force-pushed
the
fix-borrow-direct
branch
2 times, most recently
from
ceea129 to
43a8c2f
Compare
corylown
force-pushed
the
fix-borrow-direct
branch
from
43a8c2f to
779e1b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.