Reorder dockerfile to optimize build time. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* also temporarily stop using the alpine python for debug purposes
Also modified Makefile's killall command to remove stopped containers, otherwise the names are not freed..
otherwise it cannot be run without docker
For each command in a dockerfile, docker mantains a diff-image cache that can be used for incremental builds. By reordering the instructions in the dockerfile we can first get all the python dependencies that are in the requirements.txt file and then copy the rest of the code. After this commit, one should expect not a full rebuild by just changing a line of code. However, adding a new package will force a full image rebuild.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each command in a dockerfile, docker mantains a diff-image cache
that can be used for incremental builds. By reordering the instructions
in the dockerfile we can first get all the python dependencies that are
in the requirements.txt file and then copy the rest of the code.
After this commit, one should expect not a full rebuild by just changing
a line of code.
However, adding a new package will force a full image rebuild.