Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More conditions based on source column for consul sql updates #275

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

dangra
Copy link
Member

@dangra dangra commented Dec 11, 2024

missed some cases in #265

@jeromegn
Copy link
Member

This could still cause corrosion consul sync to overwrite a a service it's not supposed to, but it's going to be rare.

For example:

  • Corrosion gets a partial row update before the insert for the same primary key (e.g. only gets status = "passing")
  • Corrosion store default values for other columns (so: source = NULL) because it doesn't have enough information to build the row
  • Somehow 2 services with the same node, id are handled by Consul and the other source
  • These conditions would match even though they shouldn't.

This should be rare and only happen if multiple sources handle the same services...

@dangra dangra merged commit 47e3898 into main Dec 11, 2024
3 of 4 checks passed
@dangra dangra deleted the source-col-fixes branch December 11, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants