fix: read_physical_structures failing for multi-layer BDs.

[Didrole]

Proposal fix for issue #174

[superg]

I don't understand what you did here, it's a relatively massive code change that might affect DVD dumping (while we're fixing BluRay dumping) and taking into account that the ticket you created specifies the wrong root cause I would not rather spend time reviewing it.

I assume there is an issue with incorrectly calculated layerbreak for the disc you're trying to dump. Please create a ticket with the detail information on incorrect layerbreak value and what do you think is correct so we could establish why the calculation is wrong.

[Didrole]

I understand that the diff is a bit messy looking and I gave no explanation.
I basically moved all the BD specific logic out of the layers_count loop to clearly differentiate BD logic from DVD logic.

A simple break statement to stop the layers_count loop may be another solution (but IMO less readable).

[superg]

Let me get back to my PC tonight and I will review everything again. Just want to make sure I don't introduce any regressions while I took a break from active redumper development.

[Deterous]

I have tested this and confirmed it also fixes #153

[superg]

Ok, I pulled it locally and this is very good. I agree that it makes sense to have logic split between bluray and dvd even if there is some code duplication.

[JohnVeness]

Many thanks for working together on this - I can now dump Xbox One games (which are almost all 2 layer) which were previously failing.