code editor: find & replace #7932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Find & Replace ( ctrl + h) ( Enter : replace one and command + enter : replace all ) * Some refactoring of TextfieldPopup * Resets undoManager on luaeditor init. ( removed the empty undo state that made it possible to undo to a blank doc) * keyboard shortcuts for popups now works inside the popups as well.
|
Great stuff! 👍 |
* Fixes a bug where it indents even if the caret is positioned before the keyword
|
joel - is this ready to merge? |
mkruselj
reviewed
Dec 23, 2024
| @@ -45,8 +45,9 @@ namespace Overlays | |||
| TextfieldPopup | |||
| Base class that can be used for creating other textfield popups like the search | |||
| */ | |||
| TextfieldButton::TextfieldButton(juce::String &svg) : juce::Component() | |||
| TextfieldButton::TextfieldButton(juce::String &svg, int r) : juce::Component() | |||
There was a problem hiding this comment.
I would name this second argument more nicely so that it it's clearer, rather than guesswork.
|
Looks fine to me apart from the one comment I left. Also those inlined SVGs are kinda ugly, I would suggest moving them to |
I have one more commit where I've added find,replace and goto to the context menu. I'll also fix @mkruselj comment on the function parameter |
* changed popup font & size to the same as editor. * added find, replace and go to line to context menu
|
@baconpaul @mkruselj done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update
update 2