Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "PrettyPrinterPerformance Optimized the PrettyPrinter for #894" #906

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Revert "PrettyPrinterPerformance Optimized the PrettyPrinter for #894" #906

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions Sources/SwiftFormat/PrettyPrint/PrettyPrintBuffer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,17 +122,16 @@ struct PrettyPrintBuffer {
// In case of comments, we may get a multi-line string.
// To account for that case, we need to correct the lineNumber count.
// The new column is only the position within the last line.
var lastLength = 0
// We are only interested in "\n" we can use the UTF8 view and skip the grapheme clustering.
for element in text.utf8 {
if element == UInt8(ascii: "\n") {
lineNumber += 1
lastLength = 0
} else {
lastLength += 1
}
let lines = text.split(separator: "\n")
lineNumber += lines.count - 1
if lines.count > 1 {
// in case we have inserted new lines, we need to reset the column
column = lines.last?.count ?? 0
} else {
// in case it is an end of line comment or a single line comment,
// we just add to the current column
column += lines.last?.count ?? 0
}
column += lastLength
}

/// Request that the given number of spaces be printed out before the next text token.
Expand Down
Loading