Normalize SE-0451 author and previous proposal fields #2622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@allevato, would you like to include Alfredo as a co-author? You should probably only do so if he's interested in still participating. |
|
I reached out to Alfredo and he said it didn't matter to him either way. I just wanted to make sure he was properly attributed, and this proposal is effectively a full rewrite from the ground up, so I think this PR looks good. Thanks @dempseyatgithub ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The author field of SE-0451 includes a reference to the previous proposal that SE-0451 was based on.
The
Authorfield should only include people. The reference to a previous proposal should be in thePrevious Proposalfield.Note also that the author of the previous proposal (SE-0275) is properly credited in that proposal and does not need to be included as part of the current proposal (SE-0451) unless the author of SE-0451 wishes to include them as a co-author.
This PR normalizes the
AuthorandPrevious Proposalfields and closes swiftlang/swift-org-website#856.