[cxx-interop] Do not pass -lc++/-lstdc++ flags to the compiler
#8160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure that SwiftPM does not explicitly ask the compiler to link against a particular C++ stdlib. The Swift compiler has recently introduced support for building with C++ stdlibs which aren't the default on the target platform, specifically libc++ on Linux. The Swift Driver has logic to determine which C++ stdlib should be used, depending on the target and explicit `-Xcc -stdlib=xyz` flags, and link against the requested standard library. Similar functionality exists in Clang Driver. We should defer the C++ stdlib selection to the compiler driver, it shouldn't be necessary to duplicate it in the build system. rdar://141047307
egorzhdan
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand and
owenv
as code owners
|
@swift-ci please test |
Xazax-hun
approved these changes
Dec 6, 2024
|
@swift-ci please test Linux |
dschaefer2
approved these changes
Dec 6, 2024
jakepetroules
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The Swift compiler has recently introduced support for building with C++ stdlibs which aren't the default on the target platform, specifically libc++ on Linux. The Swift Driver has logic to determine which C++ stdlib should be used, depending on the target and explicit
-Xcc -stdlib=xyzflags, and link against the requested standard library. Similar functionality exists in Clang Driver. We should defer the C++ stdlib selection to the compiler driver, it shouldn't be necessary to duplicate it in the build system.Modifications:
This makes sure that SwiftPM does not explicitly ask the compiler to link against a particular C++ stdlib.
Result:
Projects that use libc++ on Linux build correctly with SwiftPM.
rdar://141047307