Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove legacy v1 token supports in sdk #458

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor: remove legacy v1 token supports in sdk #458

wants to merge 2 commits into from

Conversation

swimthor
Copy link
Contributor

@swimthor swimthor commented Oct 24, 2022 •
edited
Loading

Notion ticket: https://www.notion.so/exsphere/Remove-any-kind-of-legacy-support-from-the-SDK-e2bb36ec76164d2e98de8a270296e9d8

Checklist

  • Github project and label have been assigned
  • Tests have been added or are unnecessary
  • Docs have been updated or are unnecessary
  • Preview deployment works (visit the Cloudflare preview URL)
  • Manual testing in #product-testing completed or unnecessary
  • New i18n strings do not contain any security vulnerabilities (e.g. should not allow translator to update email/url)
  • When fetching new translations from external sources, do a sanity check (e.g. get people who speak the language to check, shove all new translations into Google translate)

@swimthor swimthor self-assigned this Oct 24, 2022
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 24, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 87becf7
Status: ✅  Deploy successful!
Preview URL: https://97d58d34.swim-ui.pages.dev
Branch Preview URL: https://remove-legacy-v1-code-from-s.swim-ui.pages.dev

View logs

@swimthor swimthor force-pushed the remove-legacy-v1-code-from-sdk branch from 379aead to 5d472e1 Compare October 25, 2022 10:27
@wormat wormat mentioned this pull request Oct 25, 2022
Merged
7 tasks
@swimthor swimthor force-pushed the remove-legacy-v1-code-from-sdk branch 4 times, most recently from 7cd2aa9 to ea7276a Compare October 25, 2022 20:00
@swimthor swimthor requested review from wormat and ramenuncle October 25, 2022 20:01
@swimthor swimthor marked this pull request as ready for review October 25, 2022 20:01
@swimthor swimthor force-pushed the remove-legacy-v1-code-from-sdk branch from ea7276a to 4072756 Compare October 26, 2022 09:08
wormat
wormat reviewed Oct 26, 2022
View reviewed changes
Copy link
Collaborator

@wormat wormat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a step in the right direction.

apps/ui/__mocks__/base64Mock.ts Outdated Show resolved Hide resolved
packages/token-projects/src/projects.test.ts Outdated Show resolved Hide resolved
packages/utils/src/collections.ts Show resolved Hide resolved
packages/token-projects/src/projects.ts Outdated Show resolved Hide resolved
packages/token-projects/src/projects.ts Outdated Show resolved Hide resolved
apps/ui/src/config/ecosystems/types.ts Outdated Show resolved Hide resolved
apps/ui/src/config/ecosystems/solana.ts Outdated Show resolved Hide resolved
apps/ui/src/hooks/interaction/useCrossChainEvmToEvmSwapInteractionMutation.ts Outdated Show resolved Hide resolved
apps/ui/src/config/tokens.ts Show resolved Hide resolved
apps/ui/src/config/tokenProjects.ts Outdated Show resolved Hide resolved
@wormat wormat mentioned this pull request Oct 26, 2022
Open
7 tasks
@swimthor swimthor force-pushed the remove-legacy-v1-code-from-sdk branch from 4072756 to e390122 Compare October 26, 2022 18:45
@swimthor swimthor force-pushed the remove-legacy-v1-code-from-sdk branch from e390122 to 1587efb Compare October 26, 2022 19:00
@swimthor swimthor requested review from swimdrew and wormat October 26, 2022 19:20
@swimdrew swimdrew mentioned this pull request Oct 27, 2022
Closed
7 tasks
swimdrew
swimdrew reviewed Oct 27, 2022
View reviewed changes
packages/token-projects/src/projects.ts
icon: USN_SVG,
isStablecoin: true,
isLp: false,
tokenNumber: 0x0102,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything note-worthy about removing a token project that may have allocated a token number? Is this token number re-usable?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would need to be changed in all the routing contracts. Not sure if that's possible. @swimivan? @swimricky?

Copy link
Contributor

@swimivan swimivan Oct 28, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We never had a (test)pool for it so the SwimRouter never heard of it in the first place.

And the SwimRouter also allows reuse of token numbers, so it's doubly not an issue.

So remove away.

swimdrew
swimdrew previously approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@swimdrew swimdrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed for USN removal, looks good. Can also remove mention of USN in apps/scripts

@swimthor swimthor force-pushed the remove-legacy-v1-code-from-sdk branch from 4c0979b to 87becf7 Compare October 27, 2022 17:37
wormat
wormat approved these changes Oct 28, 2022
View reviewed changes
apps/ui/src/config/ecosystems/solana.ts
wrappedDetails: EMPTY_MAP,
},
],
pools: [],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the plan to add these in a later PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will see if I can include it in next pr easily, if not I will create another PR for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swimivan swimivan swimivan left review comments

@wormat wormat wormat approved these changes

@swimdrew swimdrew swimdrew left review comments

@ramenuncle ramenuncle Awaiting requested review from ramenuncle

Assignees

@swimthor swimthor

Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swimthor @wormat @swimivan @swimdrew