Feature/test seobnrv4 phm #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change addresses two open issues where users were unable to download surrogates using wget on their machine.
vijayvarma392
requested changes
Jan 16, 2025
| @@ -56,7 +66,7 @@ | |||
|
|
|||
| original_regression_data = "model_regression_data.h5" | |||
| extra_regression_data = "model_regression_data_new.h5" | |||
| new_model = "NRHybSur3dq8_CCE" # name of new model with regression data in fp_new but not fp_old | |||
| new_model = "SEOBNRv4PHMSur" # name of new model with regression data in fp_new but not fp_old | |||
|
|
|||
There was a problem hiding this comment.
Didn't look at the code, but is ok that new_model no longer checks for NRHybSur3dq8_CCE?
There was a problem hiding this comment.
So this script (add_model_regresion.py) is only used to add new model regression data to the model regression hdf5 file. The "new_model" variable name is just pointing to the model whose data was most recently added.
Adding data is "stacking"... the hdf5 file is extended to include the new model regression data.
In short, all of the models (including NRHybSur3dq8_CCE) are still tested as before.
vijayvarma392
approved these changes
Jan 16, 2025
This was referenced Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds model regression test for new seobnrv4PHM model implemented in #52