Make FixToAtmosphere fix the electron fraction in atmosphere #6239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaaclegred
added
the
in progress
ncorsobh
reviewed
Aug 22, 2024
| spatial_metric, | ||
| eos); | ||
| ASSERT(min(rest_mass_density.get()) >= 0.0, "rest mass density should be positive"); | ||
| ASSERT(min(electron_fraction.get()) >= 0.0, "rest mass density should be positive"); |
There was a problem hiding this comment.
I think the statement should be "electron fraction should be positive" here.
isaaclegred
removed
the
in progress
isaaclegred
force-pushed
the
FixAtmosphereInReconstruction
branch
from
337796e to
992d9f9
Compare
Also add fix_to_atmosphere calls in reconstruction
isaaclegred
force-pushed
the
FixAtmosphereInReconstruction
branch
from
992d9f9 to
09c7fe2
Compare
isaaclegred
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Currently we do not perform atmosphere fixing in the hydro evolution after Finite Difference reconstruction, which can result in unphysical values of primitive variables being passed to equation of state calls leading to floating point exceptions.
Additionally, atmosphere fixing currently doesn't fix the electron fraction, which is necessary in simulations using a 3D EoS.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments
The reason why these problems are apparently coupled is because in primitive recovery unphysical electron fraction values are limited to the max/min of the EoS. However, in reconstruction the primitives are not the direct output of a con2prim call, and therefore the electron fraction is not generally snapped back to EoS bounds, and this needs to be done explicitly.