Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up ringdown script #6431

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Clean up ringdown script #6431

merged 1 commit into from
Jan 17, 2025

Conversation

AlexCarpenter46
Copy link
Contributor

Proposed changes

Cleaning and setting up the ringdown script for future updates.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@knelli2 knelli2 added this to the BBH Pipeline Automation milestone Jan 7, 2025
@knelli2 knelli2 self-requested a review January 7, 2025 20:43
@knelli2 knelli2 added the cli/pybindings Command line interface & Python bindings label Jan 7, 2025
knelli2
knelli2 requested changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!

src/IO/H5/Python/FunctionsOfTimeFromVolume.py Outdated Show resolved Hide resolved
support/Pipelines/Bbh/Ringdown.py Outdated Show resolved Hide resolved
support/Pipelines/Bbh/Ringdown.py Outdated Show resolved Hide resolved
nilsvu
nilsvu requested changes Jan 14, 2025
View reviewed changes
Copy link
Member

@nilsvu nilsvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just commenting on some Python things

support/Pipelines/Bbh/Ringdown.py Outdated Show resolved Hide resolved
support/Pipelines/Bbh/Ringdown.py Outdated Show resolved Hide resolved
support/Pipelines/Bbh/Ringdown.py Outdated Show resolved Hide resolved
support/Pipelines/Bbh/Ringdown.py Outdated Show resolved Hide resolved
knelli2
knelli2 requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And need to fix conflicts caused by #6115. Sorry, my bad!

support/Pipelines/Bbh/Ringdown.py Outdated Show resolved Hide resolved
support/Pipelines/Bbh/Ringdown.py Outdated Show resolved Hide resolved
knelli2
knelli2 reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, you can squash

@nilsvu
Copy link
Member

nilsvu commented Jan 17, 2025

No need to wait for my review

@knelli2 knelli2 merged commit bbafc33 into sxs-collaboration:develop Jan 17, 2025
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsvu nilsvu nilsvu requested changes

@knelli2 knelli2 knelli2 approved these changes

Assignees
No one assigned
Labels
cli/pybindings Command line interface & Python bindings
Projects
None yet
Milestone
BBH Pipeline Automation
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexCarpenter46 @nilsvu @knelli2