Status CLI: fix speed measurement #6442

nilsvu · 2025-01-16T22:32:17Z

Using max walltime per slab for speed measurement
instead of averaging with the min walltime.

Proposed changes

The code is documented and the documentation renders correctly. Run
make doc to generate the documentation locally into BUILD_DIR/docs/html.
Then open index.html.
The code follows the stylistic and code quality guidelines listed in the
code review guide.
The PR lists upgrade instructions and is labeled bugfix or
new feature if appropriate.

Using max walltime per slab for speed measurement instead of averaging with the min walltime.

knelli2 · 2025-01-17T17:36:24Z

support/Pipelines/EccentricityControl/EccentricityControlParams.py

        if "AhA DimensionfulSpinVector_x" in horizon_params.columns:
-            sA = np.concat(
+            sA = np.array(


Would the test not have caught this?

I think the test doesn't write spins to file atm

knelli2

Test failures unrelated.

nilsvu added the cli/pybindings Command line interface & Python bindings label Jan 16, 2025

nilsvu added 2 commits January 16, 2025 17:51

Status CLI: fix speed measurement

518f2a7

Using max walltime per slab for speed measurement instead of averaging with the min walltime.

Fix ecc control

14a8258

nilsvu force-pushed the fix_speed branch 2 times, most recently from 2b22407 to 14a8258 Compare January 17, 2025 03:12

knelli2 reviewed Jan 17, 2025

View reviewed changes

knelli2 approved these changes Jan 17, 2025

View reviewed changes

knelli2 merged commit 918181b into sxs-collaboration:develop Jan 17, 2025
41 of 48 checks passed

nilsvu deleted the fix_speed branch January 17, 2025 19:56